Skip to content

Reintroduce earliest_occurrence_time_fieldname and latest_occurrence_… #39540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: contrib/pmunaretto_reintroduce-fetch-params
Choose a base branch
from

Conversation

pmunaretto
Copy link

…time_fieldname parameters in SplunkPy integration

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: n/a

Description

In version 2.1.10 of the SplunkPy integration, the ability to customize the earliest_fetch_time_fieldname and latest_fetch_time_fieldname parameters in the oneshot fetch search was removed (#14365). These parameters are essential for dispatching the fetch search based on index_earliest and index_latest time filters, rather than the default earliest_time and latest_time.

Although the code for these parameters was reintroduced in version 2.3.0 (#16576), the corresponding parameters in the configuration file were not, making it impossible to set these values. The new parameter names are earliest_occurrence_time_fieldname and latest_occurrence_time_fieldname.

This pull request aims to reintroduce the earliest_occurrence_time_fieldname and latest_occurrence_time_fieldname parameters in the SplunkPy integration's configuration file (SplunkPy.yml) and ensure they are properly utilized in the code (SplunkPy.py).

By reintroducing these parameters, users can customize the oneshot fetch search based on specific time filters, enhancing the flexibility and usability of the SplunkPy integration.

Must have

  • Tests
  • Documentation

…time_fieldname parameters in SplunkPy integration
@pmunaretto pmunaretto requested a review from ilappe as a code owner April 9, 2025 21:38
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Apr 9, 2025
@content-bot content-bot changed the base branch from master to contrib/pmunaretto_reintroduce-fetch-params April 9, 2025 21:40
@content-bot content-bot requested a review from mmhw April 9, 2025 21:40
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Unfortunately, your PR review will be slightly delayed because of an Israeli holiday in the upcoming week (the 12th of April - the 19th of April). Thank you in advance for your patience and understanding.

@content-bot
Copy link
Collaborator

Hi @pmunaretto, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Apr 9, 2025
Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pmunaretto,
Thank you for your contribution!
Good work :)

I would appreciate it if you could explain exactly what use case you need this functionality for, this is just about Fetch.

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

@pmunaretto
Copy link
Author

Hi @mmhw,

Thank you for your kind words and feedback!

Our use case involves writing security incidents in Splunk that sometimes have a _time field set in the past, as we use the _time field to represent the first activity related to the incident. We definitely don't want to miss these incidents in our XSOAR incident ingestion. To ensure the completeness of the incidents, we want to include all newly indexed events from our incidents index in XSOAR, regardless of what the _time field is. Specifically, this means index_earliest=-15m and index_latest=now. This was possible until version 2.1.10, but not anymore.

Please feel free to reach out to me if you have any further questions.

@mmhw
Copy link
Contributor

mmhw commented Apr 23, 2025

Hi @pmunaretto,

Hi, I sent you an email.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants