Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce LoC in CSP + Readd Max Event Size Limit #38738

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

amshamah419
Copy link
Contributor

@amshamah419 amshamah419 commented Feb 23, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12927

Description

Reduces character account and re-adds the change which was removed due to the increase in character count.

(dev) ➜ content git:(reduce-loc-csp-bf) ✗ ./compare_char_counts.sh master Packs/Base/Scripts/CommonServerPython/CommonServerPython.py reduce-loc-csp-bf Packs/Base/Scripts/CommonServerPython/CommonServerPython.py
File1 -> master:Packs/Base/Scripts/CommonServerPython/CommonServerPython.py has 484822 characters
File2 -> reduce-loc-csp-bf:Packs/Base/Scripts/CommonServerPython/CommonServerPython.py has 484315 characters
Difference: -507

Changes were only applied to documentation of functions which are internally used only.

Copy link

github-actions bot commented Feb 23, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py470478183%139–142, 153, 155, 392, 434, 530, 556–560, 585, 600, 742–743, 752, 793–794, 812, 842–846, 850–852, 894, 981–989, 1033–1038, 1072–1074, 1204–1208, 1211–1212, 1214–1216, 1230–1232, 1234, 1300, 1313, 1326, 1334–1336, 1338, 1351, 1359, 1461–1462, 1517, 1539–1540, 1543, 1549, 1551, 1553, 1647, 1692, 1766–1767, 1771–1772, 1811–1812, 1826–1831, 1833, 1901, 1984, 1986, 2006, 2036, 2040, 2082, 2261, 2285, 2324–2325, 2405–2406, 2408, 2421–2428, 2430, 2507–2509, 2523, 2536, 2567, 2573–2577, 2579–2581, 2583, 2587–2588, 2590, 2603–2609, 2613, 2617–2619, 2625–2626, 2638, 2666, 2669, 2674, 2694, 2700, 2702, 2704, 2724, 2727, 2739, 2785–2793, 2795, 2854, 2876, 2896, 2954, 2966–2967, 3079, 3081, 3283, 3293, 3299, 3308, 3314, 3328, 3384, 3393, 3396, 3399, 3402, 3405, 3408, 3417, 3419, 3424–3425, 3456–3461, 3464, 3515–3516, 3519, 3685–3686, 3689, 3796, 3799, 4050, 4053, 4056, 4059, 4064, 4073, 4099, 4105, 4108, 4114, 4117, 4120, 4123, 4126, 4135, 4137, 4253–4254, 4278, 4280, 4299, 4302, 4305, 4373, 4394, 4396, 4558, 4576, 4588, 4618, 4621, 4627, 4630, 4633, 4642, 4644, 4844–4845, 4864, 4867, 4870, 4873, 4879, 4941, 4943, 4968, 4983–4999, 5002, 5006–5007, 5009–5010, 5012–5013, 5015–5016, 5018–5019, 5021–5022, 5024–5025, 5027–5028, 5030–5031, 5033–5034, 5036–5037, 5039–5040, 5042–5043, 5045, 5047–5048, 5050–5053, 5055–5057, 5059, 5061, 5065, 5141, 5181, 5187, 5189, 5199, 5237, 5242–5243, 5248, 5252–5253, 5255, 5337, 5343, 5436, 5457, 5460–5465, 5473–5479, 5481–5482, 5527, 5540, 5636–5639, 5644, 5647, 5650, 5684, 5687, 5731, 5733, 5735, 5830, 5881, 5963, 5975, 5993, 6033–6034, 6038, 6040, 6074, 6078, 6080, 6082, 6084, 6130, 6134, 6233–6236, 6238, 6251, 6270, 6280, 6286, 6295–6297, 6300–6303, 6318, 6360, 6389, 6392, 6451–6461, 6464, 6474–6475, 6477–6478, 6480–6481, 6486, 6490–6491, 6493, 6530–6533, 6536–6540, 6544, 6552, 6558, 6586, 6615, 6621–6622, 6673, 6693–6694, 6696, 6736–6737, 6744, 6749, 6755, 6768–6769, 6771, 7042–7044, 7063, 7076, 7088, 7116, 7276, 7291, 7356, 7386, 7428–7429, 7441, 7456–7457, 7459–7460, 7462–7463, 7465–7466, 7468–7471, 7473, 7475–7476, 7478, 7557–7558, 7570, 7614–7617, 7619, 7626–7627, 7787, 7842, 7878, 7898, 7900, 8001, 8161–8164, 8166–8168, 8227, 8246–8247, 8259, 8275, 8296–8297, 8299, 8316, 8403, 8417, 8420–8423, 8426, 8429, 8451–8454, 8551, 8570–8571, 8696, 8713–8715, 8751–8753, 8763–8764, 8782, 8814, 8870, 8874–8875, 8889, 8892, 8905–8907, 8910, 8982, 9152–9153, 9233–9234, 9278–9279, 9281, 9284, 9295, 9301–9304, 9306, 9308, 9310–9311, 9427, 9552, 9566, 9569, 9773, 9782, 9848–9849, 9853, 9914–9917, 9919, 9941, 9953, 10049, 10085–10086, 10099, 10112–10117, 10133–10134, 10142–10143, 10156, 10164–10165, 10182–10183, 10197, 10207, 10223, 10234, 10242–10244, 10246, 10272, 10287, 10298, 10316–10317, 10320, 10338, 10341, 10356, 10370, 10376, 10391, 10408, 10420–10428, 10431–10432, 10434, 10449–10451, 10462, 10465, 10554, 10580, 10587, 10631, 10657–10658, 10701, 10703–10705, 10707, 10782, 10791, 10912, 10976, 10980–10981, 11072–11077, 11173–11176, 11267–11269, 11295, 11329, 11379–11380, 11385–11386, 11403, 11489–11491, 11510, 11722, 11839, 11863, 11886, 11911, 11918–11924, 11926, 11928, 12029, 12032, 12085, 12136–12137, 12139–12146, 12151–12153, 12155, 12157, 12272–12273, 12292, 12330–12331, 12335, 12364–12372, 12374–12375, 12396, 12399, 12401–12402, 12404, 12406, 12408, 12410–12413, 12415, 12417–12418, 12422–12424, 12457, 12521–12522, 12524, 12532, 12541, 12545, 12547–12549, 12552–12553, 12556–12559, 12562, 12565, 12568–12575, 12577, 12588–12591, 12594, 12596–12600, 12602–12604, 12606
TOTAL470478183% 

Tests Skipped Failures Errors Time
5159 88 💤 0 ❌ 0 🔥 4m 13s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant