Skip to content

Renew Phishing Classifier #38644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Conversation

jlevypaloalto
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 13, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/DBotFindSimilarIncidents
   DBotFindSimilarIncidents.py4633792%137, 180, 201, 215, 219, 221, 238, 264–265, 267, 332, 351, 480, 484, 563, 593–594, 605–606, 610, 662–663, 665, 669, 712–716, 720, 743, 845, 878, 886, 947, 980–981
Packs/Base/Scripts/DBotFindSimilarIncidentsByIndicators
   DBotFindSimilarIncidentsByIndicators.py219199%202
Packs/Base/Scripts/DBotPredictPhishingWords
   DBotPredictPhishingWords.py1714871%23, 31–32, 39–40, 48–49, 65–66, 76–79, 86–88, 106, 108, 121, 139–140, 167, 171–180, 182–189, 250, 282–286, 296, 298
Packs/Base/Scripts/DBotPreprocessTextData
   DBotPreprocessTextData.py3584188%121, 160, 173, 187, 245, 255, 267–268, 389, 391, 394–395, 401–403, 407–413, 446–450, 453–454, 465, 483–487, 490–491, 493–494, 502, 506
Packs/Base/Scripts/DBotTrainTextClassifierV2
   DBotTrainTextClassifierV2.py30319834%49–50, 58, 68, 74, 77–78, 80–81, 88, 90, 109, 139–142, 153–154, 156–157, 167–168, 172–178, 197, 199, 211–218, 240–242, 245, 249, 259–261, 265–286, 293–302, 309–313, 315–318, 320–326, 330–331, 333–352, 356–361, 365–369, 373–376, 379–384, 386, 390–395, 399–411, 414, 416–417, 419, 421–422, 428–430, 432–449, 451, 458–463, 467–470, 483, 485
Packs/Base/Scripts/GetMLModelEvaluation
   GetMLModelEvaluation.py2133384%180, 247–248, 293–294, 299, 320, 350–354, 358–365, 367–368, 370, 378–380, 384–390
Packs/ML/Scripts/DBotPredictIncidentsBatch
   DBotPredictIncidentsBatch.py74740%1, 3–5, 7, 9, 12–21, 23–24, 27–37, 39–40, 43–44, 46–56, 59–65, 67–69, 71, 73, 79–81, 83–97
TOTAL180143276% 

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 27.657s ⏱️

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

@content-bot
Copy link
Collaborator

The following errors were thrown as a part of this pr: RN106.
The following errors cannot be ignored: RN106.
The following errors don't run as part of the nightly flow and therefore can be force merged: RN106.
##############################################################
Please note that the PR can be force merged from the validation perspective.
##############################################################

@jlevypaloalto jlevypaloalto requested a review from AradCarmi March 30, 2025 13:59
Copy link
Contributor

@AradCarmi AradCarmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!
Please see my notes.

@@ -46,7 +46,9 @@ tags:
- ml
timeout: '0'
type: python
dockerimage: demisto/pandas:1.0.0.117209
dockerimage: demisto/pandas:1.0.0.2067380
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to update this script as well? it doesn't use the updated demisto/ml image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-02 at 0 59 22

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.39.25.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.39.26.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@jlevypaloalto jlevypaloalto added docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Apr 11, 2025
@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: GR107, DO101.
The following errors can be ignored: GR107.
The following errors cannot be ignored: DO101.

nVerdict: PR can be force merged from validate perspective? ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants