Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EWS commands logic to EWS API module #38632

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

itssapir
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-12274

Description

Moved the following command logic from EWSv2/EWSO365 to EWSApiModule:

  • delete-attachment
  • get-searchable-mailboxes
  • move-item
  • move-item-between-mailboxes
  • delete-items
  • get-out-of-office
  • recover-messages
  • create-folder
  • mark-item-as-junk
  • mark-items-as-read
  • get-folder
  • expand-group

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 13, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/EWSApiModule
   EWSApiModule.py53311079%105, 113, 122–123, 133–134, 138–139, 148–149, 176, 192–196, 199, 203–206, 208, 234, 237–239, 243–245, 271–272, 274–275, 277, 279–281, 283–284, 336, 339, 384, 387, 441–443, 446, 449, 461, 491–492, 553, 555, 557–558, 564–565, 567–568, 570, 572–573, 575, 588, 591, 597–599, 626, 631, 637–639, 674, 677–679, 682, 685, 696–698, 735, 747–749, 751, 753, 944, 975, 988, 992, 1066, 1103, 1126, 1168–1169, 1194, 1217–1220, 1223–1224, 1226, 1228, 1251–1253, 1262
Packs/MicrosoftExchangeOnPremise/Integrations/EWSv2
   EWSv2.py2822491%325–326, 448, 465, 491, 496–497, 508, 513, 933–941, 1149–1150, 1158, 1162, 1166, 1442
Packs/MicrosoftExchangeOnline/Integrations/EWSO365
   EWSO365.py3474985%224, 228, 233, 245, 247, 311, 322, 496, 498, 502, 539–542, 786, 979, 1025, 1129–1130, 1286, 1292–1293, 1321–1322, 1349, 1351, 1358–1362, 1634–1636, 1639, 1658, 1696–1704, 1723, 1978–1979, 2002
TOTAL116218384% 

Tests Skipped Failures Errors Time
184 0 💤 0 ❌ 0 🔥 12.367s ⏱️

Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

##### EWS v2

- Improved the implementation by consolidating shared code between EWS integrations.
- Fixed an issue with **ews-get-out-of-office-status** failing to get the **internalReply**/**externalReply** fields.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed an issue with **ews-get-out-of-office-status** failing to get the **internalReply**/**externalReply** fields.
- Fixed an issue with ***ews-get-out-of-office-status*** failing to get the **internalReply**/**externalReply** fields.

Comment on lines +7 to +8
- Fixed an issue with **ews-get-out-of-office-status** failing to get the **internalReply**/**externalReply** fields.
- Fixed an issue causing the **ews-move-item-between-mailboxes** command to fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed an issue with **ews-get-out-of-office-status** failing to get the **internalReply**/**externalReply** fields.
- Fixed an issue causing the **ews-move-item-between-mailboxes** command to fail.
- Fixed an issue with ***ews-get-out-of-office-status*** failing to get the **internalReply**/**externalReply** fields.
- Fixed an issue causing the ***ews-move-item-between-mailboxes*** command to fail.

@ShirleyDenkberg
Copy link
Contributor

@omerKarkKatz @amshamah419 @thefrieddan1 Doc review completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants