Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search devices endpoint fix #35491

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

Shellyber
Copy link
Contributor

Status

  • Ready

Related Issues

fixes: XSUP-39445

Description

Change the request method for search-devices. function to POST instead of GET, to allow the maximum limit.

@Shellyber Shellyber requested a review from ShahafBenYakir July 18, 2024 06:57
@Shellyber Shellyber self-assigned this Jul 18, 2024
Copy link

github-actions bot commented Jul 18, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon
   CrowdStrikeFalcon.py291573174%457, 482, 522, 534, 568–569, 571–572, 590, 756–758, 773, 776, 804–813, 834, 909, 947–948, 950, 953–955, 1003, 1033, 1092–1093, 1095, 1100, 1103–1104, 1119–1121, 1126, 1129–1130, 1145–1146, 1148, 1153, 1156–1157, 1185, 1187, 1192–1193, 1203, 1205, 1210–1211, 1321, 1442, 1444, 1472, 1474, 1496–1499, 1533, 1583, 1587, 1689, 1701–1702, 1704–1705, 1708, 1710, 1714–1715, 1751, 1760, 1765, 1794, 1796, 1824, 1828, 1860, 1862, 1992, 1998, 2009–2012, 2021–2025, 2076, 2080, 2089, 2092–2093, 2096, 2105, 2108–2109, 2112, 2128, 2160, 2166–2169, 2172, 2176, 2228–2229, 2231, 2235, 2238, 2241, 2245–2246, 2249, 2264, 2423–2427, 2429–2433, 2437, 2440, 2443–2444, 2447–2449, 2451, 2460, 2462, 2676, 2681, 2685, 2726–2729, 2732, 2735, 2737–2738, 2781–2783, 2786–2788, 2790, 2811, 2903, 2929–2930, 2989–2990, 3038, 3116–3119, 3121, 3161, 3164, 3347–3348, 3533, 3637–3638, 3640, 3678–3683, 3733–3736, 3805, 3812, 3850, 3939, 3954, 3972, 3985, 4006–4009, 4022–4026, 4028–4029, 4031–4032, 4040–4048, 4055, 4099, 4105, 4133–4141, 4143–4144, 4152–4165, 4167–4168, 4170, 4172–4173, 4175–4177, 4179–4182, 4184, 4186, 4188, 4200–4208, 4210–4220, 4228–4231, 4239–4242, 4278–4281, 4300–4305, 4307–4308, 4310–4317, 4327–4328, 4331, 4547–4549, 4556, 4578–4581, 4593, 4624–4627, 4643, 4675–4678, 4698–4699, 4709, 4722–4723, 4725, 4734–4737, 4778–4779, 4797–4800, 4845–4848, 4880, 4885–4886, 4928, 4930–4931, 4971–4972, 4978, 4999–5000, 5016–5017, 5032, 5046, 5049–5050, 5058, 5061–5062, 5073, 5077, 5116–5118, 5126–5128, 5130, 5157–5166, 5197, 5264–5267, 5270–5271, 5275–5278, 5281–5282, 5291–5292, 5294, 5296, 5298, 5300–5302, 5306, 5320–5324, 5389–5391, 5393, 5396, 5398, 5401, 5403–5405, 5407, 5409–5410, 5414–5418, 5423, 5425–5426, 5430–5431, 5433–5437, 5441, 5501, 5604, 5946, 5957, 6028, 6030, 6039, 6045, 6112, 6119, 6124, 6126, 6136, 6142, 6147, 6149–6150, 6152–6154, 6156, 6164, 6182, 6191, 6197, 6215, 6223, 6228, 6230–6231, 6233–6235, 6237, 6245, 6275, 6281, 6286, 6288, 6297, 6303, 6308, 6310–6311, 6313–6315, 6317, 6325, 6379, 6381–6382, 6384–6385, 6387, 6431–6432, 6434–6435, 6442, 6444, 6449, 6528, 6557–6558, 6566–6567, 6571, 6635, 6687, 6740, 6864, 6938–6939, 6941, 6943, 6960–6962, 6964–6969, 6971–7034, 7036–7047, 7054–7067, 7069–7070, 7072–7073, 7081–7082, 7084–7085, 7087–7088, 7090–7091, 7093–7097, 7101–7105, 7109–7110, 7112–7117, 7119–7122, 7124–7173, 7175–7190, 7192, 7194–7195
TOTAL291573174% 

Tests Skipped Failures Errors Time
1056 0 💤 0 ❌ 0 🔥 19.306s ⏱️

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
@Shellyber Shellyber added the ForceMerge Forcing the merge of the PR despite the build status label Jul 18, 2024
@Shellyber
Copy link
Contributor Author

Build failed only on: Test Playbook - CrowdStrike Falcon - Retrieve File - On XSOAR SAAS
The same error that happened here: CRTX-122151

@ShahafBenYakir ShahafBenYakir merged commit 50fd1d1 into master Jul 22, 2024
15 of 16 checks passed
@ShahafBenYakir ShahafBenYakir deleted the search-devices-endpoint-fix branch July 22, 2024 08:42
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* Update search-devices to use POST

* Update release-notes

* Fixed tests

* Update Packs/CrowdStrikeFalcon/ReleaseNotes/2_0_3.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

---------

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants