Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xdr ir blocklist fix #34408

Merged
merged 3 commits into from
May 19, 2024
Merged

Xdr ir blocklist fix #34408

merged 3 commits into from
May 19, 2024

Conversation

Shellyber
Copy link
Contributor

Status

  • Ready

Related Issues

fixes: XSUP-37017

Description

Improved the command.
Added a validation for the sha256.

@Shellyber Shellyber requested a review from maimorag as a code owner May 16, 2024 15:55
@Shellyber Shellyber requested a review from ShahafBenYakir May 16, 2024 15:55
Copy link

github-actions bot commented May 16, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/CoreIRApiModule
   CoreIRApiModule.py162425584%184, 187, 192, 206, 237, 244, 258, 265, 272, 294, 340, 345, 388, 403, 414, 426, 486–487, 493–498, 523, 529, 535, 547, 557, 563, 582, 594, 600, 606, 618, 628, 634, 670, 684, 709, 738, 754, 756, 864, 894, 897, 907, 976, 982, 1002, 1008, 1010, 1037, 1053, 1239, 1263, 1269, 1282, 1284–1285, 1287, 1293–1294, 1300–1301, 1307, 1314–1315, 1348, 1350, 1396, 1403, 1410, 1416, 1422, 1429, 1436, 1446, 1476, 1552–1555, 1557–1563, 1568, 1573–1576, 1578–1579, 1581–1582, 1584–1588, 1590–1591, 1593, 1597, 1604–1605, 1620–1621, 1637, 1642, 1650, 1698–1700, 1704, 1707, 1731, 1816, 1822, 1826, 1830, 1835, 1841, 1853–1854, 1860, 1865, 1871, 1874–1876, 1908, 1911–1914, 2028, 2101, 2107, 2111, 2115, 2118, 2322, 2540, 2551, 2554–2556, 2560–2563, 2567–2568, 2574, 2576–2580, 2584, 2590, 2592–2593, 2595, 2599–2602, 2604, 2611, 2613–2614, 2617–2621, 2624, 2626, 2628, 2630–2633, 2637–2638, 2640–2645, 2647, 2678, 2853–2856, 2860–2861, 2872, 2972, 3001, 3003, 3005, 3245–3246, 3338–3340, 3348, 3369, 3483–3486, 3572, 3580, 3584–3585, 3643–3645, 3651, 3690, 3704, 3711, 3718, 3760, 3767, 3774, 3781, 3788, 3992, 4028–4031, 4033–4035, 4138, 4172, 4178, 4185, 4187, 4194, 4196, 4214, 4237
Packs/Core/Integrations/CortexCoreIR
   CortexCoreIR.py551278%36–39, 41, 44, 47, 54, 59, 62, 64, 108
Packs/CortexXDR/Integrations/CortexXDRIR
   CortexXDRIR.py5698185%59, 67, 71–73, 148–152, 154, 157, 160, 164, 232–236, 238, 245–248, 259, 262, 265, 271, 274, 300, 305, 313, 315, 318–322, 324, 393, 407–412, 444, 480, 509, 519, 578, 581, 607, 614, 616, 693–694, 696, 749, 930–932, 935, 938, 943, 997–998, 1049, 1058, 1060–1062, 1065, 1068–1069, 1106–1109, 1141, 1158
Packs/ctf01/Integrations/CortexXDRIRCTF
   CortexXDRIRCTF.py4644640%1–7, 10, 12–14, 16–18, 20, 37, 44, 52–57, 60–68, 71–72, 75–76, 79–80, 83–88, 91–98, 101, 109–121, 123–125, 128, 130, 134–138, 140, 143, 145, 153, 159, 163, 166–171, 173, 179–182, 184, 186, 208–209, 211, 216–217, 219–220, 224–225, 230–232, 238–239, 245–246, 251, 256–260, 263–264, 270–271, 277–278, 284–285, 291–292, 298–299, 301, 307, 309, 311, 319, 324, 331, 333, 335–340, 342, 344–345, 351, 358, 360–361, 367, 375, 377–378, 384, 387–389, 392, 400–402, 404, 408–410, 412, 415–416, 418–423, 426–427, 429, 432, 441–443, 445–447, 449–450, 453, 455–456, 545–552, 554, 556–557, 560, 562–563, 565, 567–568, 570, 572, 577, 580, 582–589, 591–595, 597, 599–607, 614, 616, 629, 632–636, 640–641, 646–648, 650, 652, 654, 656, 669, 671, 678, 681–685, 687, 690, 692, 695, 697, 704, 707–709, 711–713, 715–716, 718–720, 722–723, 725, 727–728, 730, 733–737, 739, 742, 746–751, 754–758, 767–768, 770–773, 775, 778–781, 783–784, 786, 789–791, 793, 795–797, 799, 801–804, 806, 809–811, 813–814, 817, 819, 823–824, 826–827, 829, 832, 835–836, 840, 843, 845–848, 850, 852, 858, 863, 868–869, 872–873, 875–877, 880, 883, 888, 894, 900, 1154, 1157, 1173–1174, 1178–1179, 1181–1182, 1184–1186, 1188–1189, 1194–1195, 1200, 1206–1208, 1210, 1212–1213, 1217–1218, 1220, 1222–1223, 1225–1227, 1233–1234, 1237–1238, 1240–1241, 1243–1245, 1247–1249, 1252, 1254–1255, 1257, 1259, 1261, 1264–1265, 1267–1268, 1273, 1278, 1281, 1283, 1291–1295, 1298, 1306, 1310, 2223–2226, 2228–2229, 2231, 2233, 2245, 2254–2256, 2258–2263, 2265, 2269, 2271, 2274, 2283, 2286–2291, 2293–2294, 2300, 2304, 2306, 2308, 2312
TOTAL271281270% 

Tests Skipped Failures Errors Time
69 0 💤 0 ❌ 0 🔥 7.406s ⏱️

@Shellyber Shellyber requested review from JudahSchwartz and removed request for maimorag May 19, 2024 06:30
@Shellyber
Copy link
Contributor Author

The build fails on Test Playbook - Cortex XDR - Retrieve File by sha256 which fails nightly also and is being handled.
Need a force merge

@Shellyber Shellyber added the ForceMerge Forcing the merge of the PR despite the build status label May 19, 2024
@ShahafBenYakir ShahafBenYakir merged commit 5945d24 into master May 19, 2024
19 of 20 checks passed
@ShahafBenYakir ShahafBenYakir deleted the xdr-ir-blocklist-fix branch May 19, 2024 13:53
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
* Blocklist updates

* RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants