Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zimperium Date Format Fix #34218

Merged
merged 6 commits into from
May 7, 2024
Merged

Zimperium Date Format Fix #34218

merged 6 commits into from
May 7, 2024

Conversation

Shellyber
Copy link
Contributor

Status

  • Ready

Related Issues

fixes: XSUP-36842

Description

Fixed the date format for the integration to the supported one.
According to the API docs and postman collection, it seems that it does not support the .%fZ but only .000Z

@Shellyber Shellyber requested a review from ShahafBenYakir May 6, 2024 06:58
Copy link

github-actions bot commented May 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Zimperium/Integrations/ZimperiumV2
   ZimperiumV2.py258697%132, 362–363, 372, 374, 472
TOTAL258697% 

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.406s ⏱️

@Shellyber
Copy link
Contributor Author

Before the fix:
image

After:
image

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. See comments

@Shellyber Shellyber merged commit a6ee070 into master May 7, 2024
17 checks passed
@Shellyber Shellyber deleted the zimperium-test-module-fix branch May 7, 2024 07:11
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
* Fixed the date format

* Added release notes and bumped version.

* Fixed validate and tests

* Fixed rn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants