Skip to content

[Cortex XDR] Improve Error Message#28932

Merged
shmuel44 merged 29 commits into
masterfrom
sk_xdr_error_message_xsup_27092
Aug 24, 2023
Merged

[Cortex XDR] Improve Error Message#28932
shmuel44 merged 29 commits into
masterfrom
sk_xdr_error_message_xsup_27092

Conversation

@shmuel44
Copy link
Copy Markdown
Contributor

@shmuel44 shmuel44 commented Aug 13, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

instated to raise an error when the XDR Identity Threat Module in the XDR instance is disabled,
now we return a warning to the war room,
(to prevent from the playbooks to fail)

  • xdr-list-risky-users
  • xdr-list-risky-hosts

Must have

  • Tests
  • Documentation

@shmuel44 shmuel44 self-assigned this Aug 13, 2023
@shmuel44 shmuel44 requested a review from dorschw August 13, 2023 15:17
@shmuel44 shmuel44 marked this pull request as ready for review August 13, 2023 15:17
@shmuel44 shmuel44 requested a review from dansterenson as a code owner August 13, 2023 15:17
…content into sk_xdr_error_message_xsup_27092
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
Comment thread Packs/Core/ReleaseNotes/2_0_6.md Outdated
Comment thread Packs/Core/ReleaseNotes/2_0_6.md Outdated
shmuel44 and others added 3 commits August 14, 2023 17:15
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
Comment thread Packs/Core/ReleaseNotes/2_0_9.md Outdated
Comment thread Packs/Core/ReleaseNotes/2_0_9.md Outdated
Comment thread Packs/CortexXDR/ReleaseNotes/5_0_11.md Outdated
@shmuel44 shmuel44 requested a review from dorschw August 23, 2023 15:53
Comment thread Packs/Core/ReleaseNotes/2_0_9.md Outdated
Comment thread Packs/CortexXDR/ReleaseNotes/5_0_11.md Outdated
@ShirleyDenkberg
Copy link
Copy Markdown
Contributor

@dansterenson @dorschw Doc review completed.

shmuel44 and others added 4 commits August 24, 2023 10:57
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 5.1.1.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@shmuel44 shmuel44 merged commit 5e7eb9a into master Aug 24, 2023
@shmuel44 shmuel44 deleted the sk_xdr_error_message_xsup_27092 branch August 24, 2023 12:02
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* added error message

* RN

* Apply suggestions from code review

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update 5_0_8.md

* fix cr

* return warning

* return warning

* revert

* revert

* revert

* test

* UT

* RN

* RN

* Update Packs/Core/ReleaseNotes/2_0_9.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/CortexXDR/ReleaseNotes/5_0_11.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update 5_0_11.md

* Update Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* cr

* copy

* Bump pack from version CortexXDR to 5.1.1.

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants