Changed the get_agent func logic to base on the platform only#25002
Merged
Conversation
Contributor
Author
|
@ShahafBenYakir - Please let me know if you think this logic change should affect other integrations. If yes I will change that in them as well. |
ShahafBenYakir
approved these changes
Mar 2, 2023
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Contributor
Author
|
This PR will be merged once the server-side fix of this issue CRTX-77146 will be merged. |
ShahafBenYakir
approved these changes
Mar 5, 2023
Contributor
|
Link to the unit tests coverage report: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
relates: CRTX-77146.
Description
As discussed in this issue CRTX-77146, the
demisto.demistoVersion()function should return platform='x2' for XSIAM machines, and platform='xsoar' for XSOAR machines (both on-prem and cloud).Therefore, we can differentiate between XSIAM to XSOAR based on the platform info only (no need to use the version).
In this PR I have changed that logic.
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have