Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desc for params in AWS-SQS #22950

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Conversation

ShirleyDenkberg
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ShirleyDenkberg ShirleyDenkberg self-assigned this Dec 11, 2022
@Shellyber
Copy link
Contributor

@ShirleyDenkberg Looks good, please see my comments before merging :)

@ShirleyDenkberg
Copy link
Contributor Author

@Shellyber Thanks. Implemented your changes.

@xsoar-bot
Copy link
Contributor

@ShirleyDenkberg ShirleyDenkberg merged commit 3dc8fb8 into master Dec 15, 2022
@ShirleyDenkberg ShirleyDenkberg deleted the ShirleyDenkberg-patch-11 branch December 15, 2022 08:55
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
* Add desc for params in AWS-SQS

* Update README.md

Done.

* Update README.md

Done.

* Update README.md

Done.

* Update README.md

Done.

* Fixed readme validaiton

Co-authored-by: sberman <sberman@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
* Add desc for params in AWS-SQS

* Update README.md

Done.

* Update README.md

Done.

* Update README.md

Done.

* Update README.md

Done.

* Fixed readme validaiton

Co-authored-by: sberman <sberman@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants