Skip to content

Ews readable errors #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenJoParadise merged 5 commits into from
Jul 12, 2018
Merged

Ews readable errors #1788

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0efdfba
Changed default authentication method to "Basic" in accordance with i…
BenJoParadise Jul 11, 2018
f1dca37
Beautified error messages in test_module
BenJoParadise Jul 11, 2018
2db9b0e
Handled case where no error message is set
BenJoParadise Jul 11, 2018
67b6aab
Release Note
BenJoParadise Jul 11, 2018
59da27f
Merge branch 'master' into ews-readable-errors
BenJoParadise Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions Integrations/integration-EWSv2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ configuration:
required: true
- display: Authentication Type (NTLM or Basic or Digest). Use Basic for Office365.
name: authType
defaultvalue: NTLM
defaultvalue: Basic
type: 0
required: true
- display: Has impersonation rights.
Expand Down Expand Up @@ -1213,28 +1213,35 @@ script:

time.sleep(2)
debug_log = log_stream.getvalue()
error_message_simple = ""
error_message = ""
if "Status code: 401" in debug_log:
error_message = "Got unauthorized from the server. " \
error_message_simple = "Got unauthorized from the server. " \
"Check credentials are correct and authentication method are supported. "

error_message += "You can try using 'domain\\username' as username for authentication. " if AUTH_METHOD_STR.lower() == 'ntlm' else ''
error_message_simple += "You can try using 'domain\\username' as username for authentication. " if AUTH_METHOD_STR.lower() == 'ntlm' else ''
if "Status code: 503" in debug_log:
error_message = "Got timeout from the server. " \
error_message_simple = "Got timeout from the server. " \
"Probably the server is not reachable with the current settings. " \
"Check proxy parameter. If you are using server URL - change to server IP address. "
error_message = error_message + "\n" + e.message

if not error_message_simple:
error_message = error_message_simple = e.message
else:
error_message = error_message_simple + "\n" + e.message

stacktrace = traceback.format_exc()
if stacktrace:
error_message += "\nFull stacktrace:\n" + stacktrace

if debug_log:
if IS_TEST_MODULE:
error_message += "\nFull debug log:\n" + debug_log
else:
demisto.info(error_message + "\nFull debug log:\n" + debug_log)
error_message += "\nFull debug log:\n" + debug_log

if not IS_TEST_MODULE:
raise Exception(error_message)
demisto.results(error_message_simple)
demisto.error("%s: %s" % (e.__class__.__name__, error_message))

raise Exception(error_message)
type: python
commands:
- name: ews-get-attachment
Expand Down Expand Up @@ -1775,3 +1782,5 @@ script:
description: Move an item from one mailbox to another.
dockerimage: demisto/py-ews:2.0
isfetch: true
releaseNotes: "Improved UX of 'Test Module' errors."