Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whois - add reliability #11789

Merged
merged 9 commits into from
Mar 22, 2021
Merged

Whois - add reliability #11789

merged 9 commits into from
Mar 22, 2021

Conversation

yaakovpraisler
Copy link
Contributor

@yaakovpraisler yaakovpraisler commented Mar 14, 2021

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

related: demisto/etc#29347

Description

Added reliability

Screenshots

Paste here any images that will help the reviewer

Minimum version of Demisto

  • 5.0.0
  • 5.5.0
  • 6.0.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@yaakovpraisler yaakovpraisler changed the title Updated review changes Whois - add reliability Mar 14, 2021
@yaakovpraisler yaakovpraisler requested a review from bakatzir March 16, 2021 08:40
Copy link
Member

@bakatzir bakatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaakovpraisler Please correlate the UT with the B - Usually reliable defaultvalue of this integration.

(cherry picked from commit 4c054fef5ff0f7294bf8cbe3e9f6a47e65dd06bd)
@bakatzir bakatzir merged commit 728c041 into master Mar 22, 2021
@bakatzir bakatzir deleted the whois_add_reliability branch March 22, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants