Skip to content

Add custom display delay support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pix106
Copy link

@pix106 pix106 commented Sep 11, 2024

I added custom delay support, do you want to merge it ?

@demestav
Copy link
Owner

Thank you for taking the time to open this pull request. One thing I would do differently, is to put the delay logic in the template tag and then pass the value with json_script.

@pix106
Copy link
Author

pix106 commented Sep 17, 2024

Hi,
I just did the same as the other global setting DJANGO_MESSAGES_DISPLAY_CLOSE_BUTTON.
Do you mean you would have added per-message delay, instead of a global settings ?
Global setting is what i wanted to add, as i'd like to adjust delay for different apps.
Both could be useful anyway IMO.

Locally i did move the default delay outside of template, which is a bit cleaner.
I'm not used to PR, idk what would happen to the PR if i rebased and force pushed to my fork :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants