-
Notifications
You must be signed in to change notification settings - Fork 19
✨ Fruity Blood Overdrive parser #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ | |
| __all__ = [ | ||
| "BooBass", | ||
| "FruityBalance", | ||
| "FruityBloodOverdrive", | ||
| "FruityFastDist", | ||
| "FruityFastDistKind", | ||
| "FruityNotebook2", | ||
|
|
@@ -67,6 +68,23 @@ class _FruityBalanceStruct(StructBase): | |
| PROPS = {"pan": "I", "volume": "I"} | ||
|
|
||
|
|
||
| class _FruityBloodOverdriveStruct(StructBase): | ||
| PROPS = dict.fromkeys( | ||
| ( | ||
| "plugin_marker", | ||
| "pre_band", | ||
| "color", | ||
| "pre_amp", | ||
| "x100", | ||
| "post_filter", | ||
| "post_gain", | ||
| "_u1", | ||
| "_u2", | ||
| ), | ||
| "I", | ||
| ) | ||
|
|
||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To support both the recent and the old version of BloodOverdrive two Structs would be used here.
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Didn't think about how big the names would get, use |
||
| class _FruityFastDistStruct(StructBase): | ||
| PROPS = dict.fromkeys(("pre", "threshold", "kind", "mix", "post"), "I") | ||
|
|
||
|
|
@@ -113,6 +131,10 @@ class FruityBalanceEvent(StructEventBase): | |
| STRUCT = _FruityBalanceStruct | ||
|
|
||
|
|
||
| class FruityBloodOverdriveEvent(StructEventBase): | ||
| STRUCT = _FruityBloodOverdriveStruct | ||
|
|
||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The BO event would set both versions of the struct, so NativePluginEvent can use the one it decides to be appropriate.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NativePluginEvent would look at the events stream and decide which plugin version it encountered.
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I need to consider whether I should just modify existing |
||
| class FruityFastDistEvent(StructEventBase): | ||
| STRUCT = _FruityFastDistStruct | ||
|
|
||
|
|
@@ -450,6 +472,80 @@ class FruityBalance(_PluginBase[FruityBalanceEvent], _IPlugin, ModelReprMixin): | |
| """ | ||
|
|
||
|
|
||
| class FruityBloodOverdrive( | ||
| _PluginBase[FruityBloodOverdriveEvent], _IPlugin, ModelReprMixin | ||
| ): | ||
| """![]()""" # noqa | ||
|
|
||
| INTERNAL_NAME = "Fruity Blood Overdrive" | ||
|
|
||
| plugin_marker = _PluginDataProp[int]() # 3 | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to expose an internal parameter in the public interface. I think this can be better exposed via a normal boolean
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was my workaround to get it to work with
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or maybe, it can be added as a property in |
||
|
|
||
| pre_band = _PluginDataProp[int]() | ||
| """Linear. | ||
|
|
||
| | Type | Value | Representation | | ||
| |---------|-------|----------------| | ||
| | Min | 0 | 0.0000 | | ||
| | Max | 10000 | 1.0000 | | ||
| | Default | 0 | 0.0000 | | ||
| """ | ||
|
|
||
| color = _PluginDataProp[int]() | ||
| """Linear. | ||
|
|
||
| | Type | Value | Representation | | ||
| |---------|-------|----------------| | ||
| | Min | 0 | 0.0000 | | ||
| | Max | 10000 | 1.0000 | | ||
| | Default | 5000 | 0.5000 | | ||
|
|
||
| """ | ||
|
|
||
| pre_amp = _PluginDataProp[int]() | ||
| """Linear. | ||
|
|
||
| | Type | Value | Representation | | ||
| |---------|-------|----------------| | ||
| | Min | 0 | 0.0000 | | ||
| | Max | 10000 | 1.0000 | | ||
| | Default | 0 | 0.0000 | | ||
| """ | ||
|
|
||
| x100 = _PluginDataProp[bool]() | ||
| """Boolean. | ||
|
|
||
| | Type | Value | Representation | | ||
| |---------|-------|----------------| | ||
| | Off | 0 | Off | | ||
| | On | 1 | On | | ||
| | Default | 0 | Off | | ||
| """ | ||
|
|
||
| post_filter = _PluginDataProp[int]() | ||
| """Linear. | ||
|
|
||
| | Type | Value | Representation | | ||
| |---------|-------|----------------| | ||
| | Min | 0 | 0.0000 | | ||
| | Max | 10000 | 1.0000 | | ||
| | Default | 0 | 0.0000 | | ||
| """ | ||
|
|
||
| post_gain = _PluginDataProp[int]() | ||
| """Linear. | ||
|
|
||
| | Type | Value | Representation | | ||
| |---------|-------|----------------| | ||
| | Min | 0 | -1.0000 | | ||
| | Max | 10000 | 0.0000 | | ||
| | Default | 10000 | 0.0000 | | ||
| """ | ||
|
|
||
| _u1 = _PluginDataProp[int]() | ||
| _u2 = _PluginDataProp[int]() | ||
|
|
||
|
|
||
| @enum.unique | ||
| class FruityFastDistKind(enum.IntEnum): | ||
| """Used by :attr:`FruityFastDist.kind`.""" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.