Sanitize filename #4635
Open
Sanitize filename #4635
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not remove any special characters, but avoids path manipulations being passed together with msg.filename |
| @@ -374,6 +382,8 @@ export async function copyFileToInternalTmpDir( | |||
| ): Promise<string> { | |||
| const sourceFileName = basename(sourcePath) | |||
| const sourceDir = dirname(sourcePath) | |||
| // make sure fileName includes only a file name, no path or whatever | |||
| fileName = basename(normalize(fileName)) | |||
There was a problem hiding this comment.
Why is normalize() needed? Shouldn't basename() be enough?
There was a problem hiding this comment.
was not sure if basename can be "tricked" if it gets an unexpected argument, while normalize is obviously created for "normalizing" but may be I exagerate...
There was a problem hiding this comment.
All good. Better safe than sorry!
ralphtheninja
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog