🚧 Virtualize chatview #1685
Closed
🚧 Virtualize chatview #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
force-pushed
the
virtualize-chatview
branch
2 times, most recently
from
4277267
to
3494385
Compare
somehow it doesn't work yet
- huge messages bvaughn/react-virtualized#610 - doesn't start at bottom - image height - context menu missing - scrolling is lagging (throws you forward and backwards a bit while scrolling) - and likely even more bugs
and move message context menu to own file
and keyboard shortcut to jump to end of chat
|
we should backport the extraction/deduplication of the messagecontext menu to master and then rebase this branch. |
|
lets close this for now and put it into project resurrection / use it as reference later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
problems to solve:
probably Dynamic height + scrolling up (when the upper cells aren't loaded yet) bvaughn/react-virtualized#610