Fix MessageList not updating/scrolling down on incoming message #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
reviewed
Dec 12, 2019
| @@ -41,8 +41,10 @@ export default function MessageList ({ chat, refComposer, locationStreamingEnabl | |||
|
|
|||
| useEffect(() => { | |||
| if (scrollToBottomIfClose === false) return | |||
| if (messageListRef.current.scrollHeight - messageListRef.current.scrollTop > 400) { | |||
| // we are close to bottom so scroll down to show the new message | |||
| // For whatever reason the scrollTop is ~1000 off... | |||
There was a problem hiding this comment.
For the protocol: I do not like this "we don't know what its doing lets fix it anyway somehow" approach
There was a problem hiding this comment.
Me neither. Feel free to figure it out, didn't find the reason for this. Actually i threw out that code path as it's weird ux.
|
The scrolling is not working (I only tested it with the window in the background) but the update bug is fixed so I will approve |
Simon-Laux
approved these changes
Dec 12, 2019
nicodh
reviewed
Dec 13, 2019
| @@ -66,8 +66,7 @@ chatStore.reducers.push(({ type, payload, id }, state) => { | |||
| messages: { | |||
| ...state.messages, | |||
| ...payload.messagesIncoming | |||
| }, | |||
| scrollToBottomIfClose: true | |||
There was a problem hiding this comment.
this line is needed: in my tests it only scrolls down if this is true. Why did you remove it?
|
For whatever reason some commits aren't shown in this pr, this is probably why stuff is missing. Not sure why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222