Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji sorted inmediately in "Frequently Used" category #1177

Closed
adbenitez opened this issue Dec 5, 2019 · 8 comments · Fixed by #1920
Closed

Emoji sorted inmediately in "Frequently Used" category #1177

adbenitez opened this issue Dec 5, 2019 · 8 comments · Fixed by #1920

Comments

@adbenitez
Copy link
Member

adbenitez commented Dec 5, 2019

When user click an emoji in the "Frequently Used" category it is re-sorted immediately, which causes some troubles when user clicks several times an emoji and then it change position with another emoji and a wrong emoji is inserted by accident, list should be updated when opening the emoji popup menu again, once open keep current emojis in current position (as done in DC-Android currently)

  • Platform (linux/mac/windows): GNU/Linux
  • Delta Chat Desktop Version: current master (some hours ago)
@adbenitez
Copy link
Member Author

(please note this reports are due I am testing Delta Chat Desktop, I'm NOT requesting to tackle ASAP)

@Simon-Laux
Copy link
Member

Simon-Laux commented Dec 5, 2019

We use a library for the emoji picker.
So we need to ask https://github.com/missive/emoji-mart for a solve.

@Jikstra
Copy link
Contributor

Jikstra commented Dec 5, 2019

Or hack around the library ^^

@Simon-Laux
Copy link
Member

Or hack around the library ^^

Not in this case, its too deep in it.. maybe to solve #1181, but not for this one.

@Simon-Laux
Copy link
Member

looks this isue was already fixed in emoji mart so we just need to update the dependency missive/emoji-mart#366
missive/emoji-mart#417

@Simon-Laux
Copy link
Member

Simon-Laux commented Jul 24, 2020

but the version we need isn't released yet, so we need to wait.

@Jikstra
Copy link
Contributor

Jikstra commented Jul 24, 2020

Can we depend on the git of emoji mart and pin to a specific commit?

@Simon-Laux
Copy link
Member

Looks like there were already a few new versions, but they are not documented in the release section only as tags and in the changelog. So we can probably upgrade to version 3, but it has some breaking changes so we need to keep an eye on https://github.com/missive/emoji-mart/blob/master/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants