Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #1376

Merged
merged 1 commit into from
May 22, 2020
Merged

fix typo #1376

merged 1 commit into from
May 22, 2020

Conversation

r10s
Copy link
Member

@r10s r10s commented May 21, 2020

closes deltachat/deltachat-ios#738

requires a source-update on transifex after merging.

Copy link
Member

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ;)

@angelo-fuchs
Copy link
Collaborator

I'm surprised we fix a typo on iOS with a commit on Android. Otherwise lgtm.

@r10s
Copy link
Member Author

r10s commented May 22, 2020

@angelo-fuchs the typo was not only on ios, it was on android and desktop as well. with this pr, it is fixed on all platforms.

we're using the same strings on all platforms. android, ios and desktop all pull from the same transifex-repo, but the upstream is typically handled here.

@r10s r10s merged commit 0723dbf into master May 22, 2020
@r10s r10s deleted the fix-typo branch May 22, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"them it" in the login_error_server_response string
3 participants