clippy: fix for new rust stable 1.85 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramaters -> parameters
… crate; allow overriding the binaries 2d14ff7 fix minimal versions of serde (Andrew Poelstra) a39988d ci: pin deps for 1.41.1 (Andrew Poelstra) febf493 remove unused fuzztarget feature (Andrew Poelstra) e630d82 commit a bitcoind and elementsd binary to the repo (Andrew Poelstra) f3acee0 elementsd-tests: clean up (Andrew Poelstra) da9deae elementsd-tests: make bitcoind and elementsd paths configurable (Andrew Poelstra) f773496 elementsd-tests: consolidate setup code (Andrew Poelstra) 7bbf981 move elementsd tests to their own crate (Andrew Poelstra) Pull request description: I need this to test this crate within Nix. ACKs for top commit: sanket1729: ACK 2d14ff7. We can debug `tx-pegin` test later Tree-SHA512: 44e293d1d587cf2bc5e4185e3babe054b6462172c637f7b01ece02523f9c34cf48f0a286f312077676b4740e4629dc2df54ba38b80d56abb9468beff21e7c8d9
dc6f520 Make TxOut generic in Prevouts (Christian Lewe) Pull request description: Useful when prevouts are saved in a vector. ACKs for top commit: apoelstra: ACK dc6f520 Tree-SHA512: c9981753ed6a7bbf492541e4a17a3e6be36dabb7e26f57453cb14e7befbc13f5f0c3181cfc8c10a110734dc186870834a2a96af47884c1c5a22a974855d82fc6
7b3f081 Add From implementations (Christian Lewe) d58610e Add from_keypair (Christian Lewe) 4eed656 Add TweakedKeyPair methods (Christian Lewe) 19ff852 Add TweakedKeyPair (Christian Lewe) 063a8f5 Update TapTweak (Christian Lewe) Pull request description: Updates `TapTweak` to [latest rust-bitcoin](https://docs.rs/bitcoin/latest/bitcoin/key/trait.TapTweak.html) and adds `TweakedKeyPair`. ACKs for top commit: apoelstra: ACK 7b3f081 Tree-SHA512: 6a842533ce9a4483b3618b8a395b223f6943cd3ba79588805d65ad4ddbd04fac17f03a1eadaaecef267035d8a6dac8ac075e4c2ecee8e27134929c6073728ef5
b14f1a3 Remove std feature gates (Christian Lewe) Pull request description: There is no `std` feature in rust-elements. This is a copy-and-paste error from rust-bitcoin. ACKs for top commit: apoelstra: ACK b14f1a3 Tree-SHA512: 4cce9e662e3191a36cd5acf78e4dec668c731ed43e2998ac7afbb7066e8714e02f198ea63e7c571e62285f5c76983522307bb9a053e3dcb34a84a37a26f3ccdf
Requires updating bitcoin to 0.30.0, at least for the elementsd tests, but this is easier than dealing with the dependency mess of 0.6.0.
c49ce3f fix decoding error (caught by fuzz test) (Andrew Poelstra) 93b12bc update elementsd to 0.8.0 (Andrew Poelstra) b537c23 add doccomment to all pub extern crates; export a couple more crates (Andrew Poelstra) Pull request description: Currently master is failing CI for a couple reasons. Fix these. ACKs for top commit: delta1: ACK c49ce3f Tree-SHA512: 39c01564ce7d292f15996fd5bef3a87917f873bcc7f2b305cff33a27f76e5d49f27a26af1359cf24a527a80caa5d10003bdc8fb8986a86052417a87b1b8087a2
Otherwise we miss them when upgrading to 0.32
… bitcoin::Encodable c08382c Copy ReadExt/WriteExt from bitcoin (Riccardo Casatta) 4aad862 Stop implementing elements::Encodable with bitcoin::Encodable (Riccardo Casatta) Pull request description: Following bitcoin versions change `io` with `bitcoin_io`, upgrading would then require changing also elements::Encodable to match. Instead, we are re-implementing what is needed. Makes ElementsProject#209 easier ACKs for top commit: apoelstra: ACK c08382c successfully ran local tests; a bit redundant but I think this is the right way to go Tree-SHA512: e849dc141ab412f1db3539a132688b28e2770befb8fc46e64d3396f16c3b9035bb7d76a0813d4d7bf65ff85df418cb42e8d75e01d1db7879c5853dd40214e053
avoid setting {BITCOIND,ELEMENTSD}_EXE in setup
The logic of setting the env var inside the setup prevents user of other
OS like nixos to run the tests (because the included binary are not
working on nixos).
Setting those env vars is meant to be done in the dev environment not in
the code.
With this users with `bitcoind` and `elementsd` in their PATH will work
too.
The CI script will set the variables only if they are not already set.
(Allowing Nixos users to override and run it locally)
f889525 improve logging on error (Riccardo Casatta) 802c006 upgrade bitcoin 0.31 -> 0.32, fix test env vars (Riccardo Casatta) Pull request description: ElementsProject#208 ``` fn consensus_encode<W: bitcoin::io::Write + ?Sized>(&self, e: W) -> Result<usize, crate::encode::Error> {} fn consensus_decode<R: bitcoin::io::BufRead + ?Sized>(reader: &mut R) -> Result<Self, crate::encode::Error> {} ``` We went for not depending on bitcoin::Encodable instead ACKs for top commit: apoelstra: ACK f889525 successfully ran local tests Tree-SHA512: 23fbf597c7adad52c40f1c26b2d0cad6755a0ff8f9da3ee498d2dd80856b24f557f2f7bf504712a6d25e358d5417fc5f7c467122470d9087f93f1e7d260e5539
There is a new clippy/rustc nightly lint about having massive paragraphs as the first line of doccomments. The first line is treated specially and should be reasonably short.
We missed this when porting the rust-bitcoin decoding code to rust-elements. But fortunately the fuzzer caught it very quickly.
User code can already compare against AddressParams, but it seems more easy to find a method to check if the address is liquid. Even thoug is less general because you can't discriminate between elements and liquid testnet, most of the time wallets are interested only in the mainnet or not discrimination.
17578d7 add Address::is_liquid (Riccardo Casatta) Pull request description: User code can already compare against AddressParams, but it seems easier to find a method to check if the address is liquid. Even tough is less general because you can't discriminate between elements and liquid testnet, most of the time wallets are interested only in the mainnet or not discrimination. ACKs for top commit: apoelstra: ACK 17578d7 successfully ran local tests; sure Tree-SHA512: e2d47a1ed8880c3c54ddb9c8812f0ae0bc321f74747eb2b45c1078f1afe63a73c910849d2c75b8af6f41600163fd6b156d5ac72e9c263c2a99f3a0fcee217643
14a625f bump version 0.24.1 -> 0.25.0 (Riccardo Casatta) Pull request description: ACKs for top commit: apoelstra: ACK 14a625f successfully ran local tests; looks good -- the list is small enough that I think it's fine to include even trivial ones like doc changes Tree-SHA512: 9cfa216f6e8f160f4274254108f9b355fbe7e6a507cec51622841e319b1c7794bed56610a2235ec3b83636c7cb35be4852d81698741419b2ee5c883e1d500f59
6909e1c discount: fix calculation to weight amount and nonce by witness scaling factor (Byron Hambly) Pull request description: output amount and nonce discount must be weighted by the witness scaling factor as they form part of the base transaction, not the witness data see ElementsProject/elements#1366 ACKs for top commit: apoelstra: ACK 6909e1c successfully ran local tests; though I note that if we had a Weight type here like in rust-bitcoin we likely would have caught this :/ Tree-SHA512: 4348d32a980088e7426c03c5c9f42bfb130fefbbe18167725e75a6decff4acb069b4f2dea3d8eb1beac1d93a7c16e7acc9ee1f47f8953ffb4e786fb5fe430dc3
… 1.56.1 compilation 01b0d2c ci: pin libc to 0.2.163 for rust 1.56.1 (Byron Hambly) 7f39702 clippy: fix stable clippy issues (Byron Hambly) Pull request description: Fixes clippy for the stable CI job, and pins libc to 0.2.163 for the rust 1.56.1 job ACKs for top commit: RCasatta: ACK 01b0d2c apoelstra: ACK 01b0d2c; successfully ran local tests; thanks! Tree-SHA512: e2d1a04217264bcf8ec81fac5936a10aaa4b306b1b733eec47245d7cd7b93a09bebe1d9626128ad1e2b7b26277560e791f5c7d8c5bb413fb6a4e25e622fa1ea8
…lementsProject#204 66110dc tx: discountct: add missing testcase from ElementsProject#204 (Pablo Greco) Pull request description: In ElementsProject#204 we included a lot of files for discountCT test cases, but one of the files was never tested (2in3out_tx.hex). This is just the testing of that file. ACKs for top commit: apoelstra: ACK 66110dc; successfully ran local tests Tree-SHA512: 8aba1ce9ed824187246c01783ace9498ff7ad9e6690ac7cacb5e40d676232fef2e551dabff3d964678ef28f890a835809dcd5c3f6c0d769cbdab7cd0f639d5e8
In Elements 22 there was a change in the `createpsbt` RPC that causes our integration tests to fail. This is fixed by disabling blinding. Patch by Leo Comandini, adapted by me to still work with 0.21, from ElementsProject#214
…ts-22+ elementsd-tests: blind asset issuance based on node version
Fix WASM build and add a job in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hexmodule which is basically a copy/paste from bitcoin_hashes 0.11hexmoduleas_refwhich seems weirdly fragile