Changed fetch request when submit button is pressed #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaran-14
reviewed
Mar 17, 2021
Comment on lines
+15
to
+16
| yield call(SubmissionFetch.lockCode); | ||
| yield put(NotificationActions.success('Code Locked')); |
There was a problem hiding this comment.
@ElzaCS @ram2091999 @bestinbthomas Is lockcode something you sill want?
Doesn't it clutter the submitbar?
There was a problem hiding this comment.
Yes. The code used for matches with other players that affect their rating, should be saved separately. If a user is on the leaderboard, they should be ready to be challenged by another player. In such a situation, if a user is in the middle of improvising their code, the latest submitted code would be used for the match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.