Skip to content

Feat : Home,commit history,dc modal #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 15, 2023
Merged

Conversation

shubham-1806
Copy link
Contributor

@shubham-1806 shubham-1806 commented Jan 8, 2023

To Do :

  • Add Particle Effect

Fixes #4

Copy link
Collaborator

@Ram-20062003 Ram-20062003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Requested

Please follow the figma provided

Home-Page

  • Import fonts from google-fonts and then use it . Bai Jamjuree will not be present by default
  • Change the Footer in the front-page. Change the design according to our new colour palette
  • Giver darker bg for Made with ❤️ by delta. Match it with our new design.
  • Look into responsiveness,
     1. Text overflow in About page for mobiles.
     2. Reduce font-size accordingly
     3. Have little margin
  • The arrow in the home page should move to second segment when clicked

Commit History Page

  • Use proper fonts here
  • Change the react-code-blocks theme are from aotmonedark to iRBlack
  • The commit msg area box should be of uniform size. Should not change for longer commit messages.
  • Follow proper dimensions and colour as mentioned in figma
  • Vertical timeline component boxes are supposed to be translucent
  • Upon clicking Load Commit, the committed code should be loaded in main editor
  • Make sure the page is responsive upto 13.1 inches laptop (1248px).

Daily Challenge

  • Change the color pallete of the dropdown. Match it with the theme

General Changes

  • Remove commented and redundant codes
  • Give proper names to the variables
  • Figure out a proper particle background.
  • Remove unwanted files too

Please get these changes done asap. If you have any doubts let me know

Copy link
Collaborator

@Ram-20062003 Ram-20062003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI-Changes

Commit-History Page

image

  • Limit the height accordingly to the map view box height

Home-Page

  • Replace the image with previous year map image
    image
  • We can have video-loop background here too.

General Changes

  • Play the video-loop slower (0.2x) and once the video is done play it in reverse direction
  • Remove these un-necessary files. model.json and binary

(Make sure to do these and the below changes @shubham-1806)

@Ram-20062003 Ram-20062003 merged commit ce19941 into main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit-History,Home,DC Modal
4 participants