Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK] Add common sql test utility methods to DeltaSQLTestUtils #4131

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

stefankandic
Copy link
Contributor

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Adding the most commonly used methods in testing; such as getting the delta log, snapshot, protocol, stats, columns etc in DeltaSQLTestUtils so that we don't have to keep reimplementing them over and over again and just use this trait instead.

How was this patch tested?

No testing required.

Does this PR introduce any user-facing changes?

No.

@stefankandic stefankandic force-pushed the stefankandic/addTestUtils branch from 23f4af3 to d655dcd Compare February 13, 2025 12:43
@stefankandic stefankandic force-pushed the stefankandic/addTestUtils branch from d655dcd to 849d9c5 Compare February 18, 2025 16:17
Copy link
Collaborator

@johanl-db johanl-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding these

@scottsand-db scottsand-db merged commit e621c5d into delta-io:master Feb 20, 2025
16 of 21 checks passed
anoopj pushed a commit to anoopj/delta that referenced this pull request Feb 24, 2025
…elta-io#4131)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [X] Spark
- [ ] Standalone
- [ ] Flink
- [ ] Kernel
- [ ] Other (fill in here)

## Description
Adding the most commonly used methods in testing; such as getting the
delta log, snapshot, protocol, stats, columns etc in `DeltaSQLTestUtils`
so that we don't have to keep reimplementing them over and over again
and just use this trait instead.

## How was this patch tested?
No testing required.

## Does this PR introduce _any_ user-facing changes?
No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants