[Infra] Separate out delta-spark python tests #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Aug 13, 2024
| # Python tests are run only when spark group of projects are being tested. | ||
| is_testing_spark_group = args.group is None or args.group == "spark" | ||
| # Python tests are skipped when using Scala 2.13 as PySpark doesn't support it. | ||
| is_testing_scala_212 = scala_version is None or scala_version.startswith("2.12") |
There was a problem hiding this comment.
the scala version is part of the GH workflow configuration
nastra
force-pushed
the
separate-out-python-tests
branch
2 times, most recently
from
9f9adb9 to
0644535
Compare
nastra
changed the title
nastra
force-pushed
the
separate-out-python-tests
branch
from
0644535 to
a0c6ecc
Compare
nastra
force-pushed
the
separate-out-python-tests
branch
from
a0c6ecc to
2491b13
Compare
|
Before this PR:
With this PR:
|
|
Hi, could you also consider this PR? It may help a bit: #2690 |
nastra
force-pushed
the
separate-out-python-tests
branch
from
62a6f00 to
883a2a2
Compare
|
we also need to split out the same for the spark master isn it? |
nastra
force-pushed
the
separate-out-python-tests
branch
from
883a2a2 to
e28ff7c
Compare
scottsand-db
force-pushed
the
separate-out-python-tests
branch
from
e28ff7c to
729efbb
Compare
|
@tdas << we also need to split out the same for the spark master isn it? >> we don't run python tests for spark master at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Separate out delta-spark python tests to their own GitHub CI
How was this patch tested?
CI tests
Does this PR introduce any user-facing changes?
No