[INFRA] Move checkstyle config files to one location #3056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
reviewed
May 7, 2024
There was a problem hiding this comment.
It's empty/unused. We just need to have a checkstyle-supressions.xml file in the same location as the checkstyle.xml (for checkstyle to work) so we don't need these anymore.
scottsand-db
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Currently the java checkstyle config files are shared by some projects and stored in different locations nested under those projects. Moves the checkstyle config files to a common location. This will make it easier to compare our configs in the future and keep track of the different settings for the different projects.
How was this patch tested?
Locally ran
checkstylefor all the affected projects. Also modified one file and checked that the checks failed.