[Spark] Rename FileNames.deltaFile to FileNames.unsafeDeltaFile #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeet-db
force-pushed
the
rename-1
branch
3 times, most recently
from
dafac6b to
4f0671c
Compare
prakharjain09
approved these changes
Apr 8, 2024
andreaschat-db
pushed a commit
to andreaschat-db/delta
that referenced
this pull request
Apr 16, 2024
…a-io#2838) #### Which Delta project/connector is this regarding? - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Previously, certain code paths assumed the existence of delta files for a specific version at a predictable path `_delta_log/$version.json`. This assumption is no longer valid with managed-commits, where delta files may alternatively be located at `_delta_log/_commits/$version.$uuid.json`. We explicitly rename the old method to `unsafeDeltaFile` to warn future users about it being incorrect for tables with Managed Commits. To not break dependent systems, plan: 1. Update all delta-spark usages to use the unsafe method. (current PR) 2. Deprecate the deltaFile method. (current PR) 3. Remove the deprecated method once it's proven to be safe. (future PR) ## How was this patch tested? UTs ## Does this PR introduce _any_ user-facing changes? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Previously, certain code paths assumed the existence of delta files for a specific version at a predictable path
_delta_log/$version.json. This assumption is no longer valid with managed-commits, where delta files may alternatively be located at_delta_log/_commits/$version.$uuid.json. We explicitly rename the old method tounsafeDeltaFileto warn future users about it being incorrect for tables with Managed Commits.To not break dependent systems, plan:
How was this patch tested?
UTs
Does this PR introduce any user-facing changes?
No