Error out if there is a cardinality mismatch for a DV after decoding #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-samwel
reviewed
Sep 19, 2023
|
|
||
| // Verify that the cardinality in the bitmap matches the DV descriptor. | ||
| if (bitmap.cardinality != dvDescriptor.cardinality) { | ||
| recordDeltaEvent( |
There was a problem hiding this comment.
Should this error out?
…ality in the descriptor
olaky
force-pushed
the
dv-cardinality-validation
branch
from
89580cb to
d741d32
Compare
olaky
changed the title
scottsand-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Check DV cardinality when reading DVs
Update DeletionVectorStore to verify that the cardinality of the DVs we read from files are the expected ones.
Does this PR introduce any user-facing changes?
No