Fix cargo clippy issues 0.1.65 in Rust #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvaleye
requested review from
houqp,
xianwill,
wjones127,
roeap,
rtyler and
mosyp
as code owners
|
To track the issue with the |
rtyler
reviewed
Nov 8, 2022
| @@ -31,7 +31,7 @@ pub type MinAndMaxValues = ( | |||
| pub(crate) fn apply_null_counts( | |||
| array: &StructArray, | |||
| null_counts: &mut HashMap<String, ColumnCountStat>, | |||
| nest_level: i32, | |||
| _nest_level: i32, | |||
There was a problem hiding this comment.
This one surprises me to see @fvaleye since the nest_level variable does get used within the function body 😕
There was a problem hiding this comment.
Yes, good point @rtyler, I was also surprised to see clippy raising an error on this one... I'll take a closer look.
There was a problem hiding this comment.
FYI
76 | #![deny(warnings)]
| ^^^^^^^^
= note: `#[deny(clippy::only_used_in_recursion)]` implied by `#[deny(warnings)]`
note: parameter used here
--> rust/src/writer/stats.rs:57:77
9e5c7ac
to
91cef97
Compare
wjones127
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
0.1.65