Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update runs-on value in python_release.yml #1940

Merged
merged 3 commits into from
Dec 5, 2023
Merged

chore: update runs-on value in python_release.yml #1940

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
573cbd1
Update runs-on value in python_release.yml
wjones127 Dec 5, 2023
95cf5be
Merge branch 'main' into fix-build
ion-elgreco Dec 5, 2023
984b56c
fix path
ion-elgreco Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update runs-on value in python_release.yml
  • Loading branch information
@wjones127
wjones127 committed Dec 5, 2023
commit 573cbd139a5607d72d12fc0480884d8a517275b3
30 changes: 3 additions & 27 deletions .github/workflows/python_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,47 +35,23 @@ jobs:
fail-fast: false
matrix:
target: [x86_64-apple-darwin, aarch64-apple-darwin]
runs-on: macos-11
runs-on: macos-12
steps:
- uses: actions/checkout@v3

# We use extra recent Cargo.toml syntax, so we need at least Rust 1.71.0
- name: Install newer rust
uses: actions-rs/toolchain@v1
with:
profile: default
toolchain: stable
override: true

Comment on lines -42 to -49
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer runner has Rust 1.73.0: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#rust-tools

- name: Publish to pypi (without sdist)
uses: messense/maturin-action@v1
env:
MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
with:
target: ${{ matrix.target }}
command: publish
args: -m python/Cargo.toml --no-sdist ${{ env.FEATURES_FLAG }}

release-pypi-mac-universal2:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anyone really has need for this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those feature flags setting there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean this?

delta-rs/.github/workflows/python_release.yml

Lines 12 to 14 in 573cbd1

# For ease of development, we make rustls default. But for release we should
# use native TLS.
FEATURES_FLAG: --no-default-features --features native-tls

needs: validate-release-tag
name: PyPI release on Mac universal 2
runs-on: macos-latest
steps:
- uses: actions/checkout@v3

- name: Publish to pypi (without sdist)
uses: messense/maturin-action@v1
env:
MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
with:
target: ${{ matrix.target }}
command: publish
args: --skip-existing -m python/Cargo.toml --no-sdist --universal2 ${{ env.FEATURES_FLAG }}
args: --skip-existing -m python/Cargo.toml --no-sdist ${{ env.FEATURES_FLAG }}

release-pypi-windows:
needs: validate-release-tag
name: PyPI release on Windows
runs-on: windows-2019
runs-on: windows-latest
steps:
- uses: actions/checkout@v3

Expand Down