Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rustls default across all packages #1097

Merged
merged 14 commits into from
Feb 11, 2023
Prev Previous commit
Next Next commit
what if we made rustls default
  • Loading branch information
wjones127 committed Feb 11, 2023
commit 419316f8a2b7f35fa7ff5186af35206eaa6fffba
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,5 @@ jobs:
override: true
- uses: Swatinem/rust-cache@v2
- name: Run tests
run: cargo test --no-default-features --features=parquet2
working-directory: rust
run: cargo test --no-default-features --features=parquet2,native-tls
2 changes: 1 addition & 1 deletion aws/delta-checkpoint/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ rusoto_credential = "0.48"
rusoto_s3 = { version = "0.48", default-features = false }

[features]
default = ["native-tls"]
default = ["rustls"]
native-tls = ["rusoto_core/native-tls", "rusoto_s3/native-tls"]
rustls = ["deltalake/s3-rustls", "rusoto_core/rustls", "rusoto_s3/rustls"]

Expand Down
2 changes: 1 addition & 1 deletion delta-inspect/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ env_logger = "0"
[dependencies.deltalake]
path = "../rust"
version = "0"
features = ["azure", "glue", "gcs"]
features = ["s3", "azure", "glue", "gcs"]
2 changes: 1 addition & 1 deletion dynamodb_lock/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ maplit = "1"
tokio = { version = "1", features = ["fs", "macros", "rt", "io-util"] }

[features]
default = ["native-tls"]
default = ["rustls"]
native-tls = ["rusoto_core/native-tls", "rusoto_dynamodb/native-tls"]
rustls = ["rusoto_core/rustls", "rusoto_dynamodb/rustls"]
4 changes: 2 additions & 2 deletions python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ version = "0"
features = ["azure", "gcs", "python", "datafusion"]

[features]
default = ["native-tls"]
default = ["rustls"]
native-tls = ["deltalake/s3", "deltalake/glue"]
rustls = ["deltalake/s3-rustls"]
rustls = ["deltalake/s3-rustls", "deltalake/glue-rustls"]
4 changes: 4 additions & 0 deletions rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ s3-rustls = [
"object_store/aws_profile",
]
glue = ["s3", "rusoto_glue"]
glue-rustls = [
"s3-rustls",
"rusoto_glue/rustls"
]
python = ["arrow/pyarrow"]

# used only for integration testing
Expand Down