Skip to content

Inconsistent units of time #2256

Closed
@cmackenzie1

Description

@cmackenzie1

Environment

Delta-rs version: latest

Binding: rust

Environment:

  • Cloud provider:
  • OS:
  • Other:

Bug

What happened:

Sometimes duration fields suffixed with _ms report time as milliseconds (expected), but other times they are reported as microseconds.

https://github.com/delta-io/delta-rs/blob/main/crates/core/src/operations/update.rs#L400

https://github.com/delta-io/delta-rs/blob/main/crates/core/src/operations/delete.rs#L204

What you expected to happen:

All fields using _ms should be in milliseconds.

_ms -> milliseconds
_us -> microseconds

How to reproduce it:

More details:

Microsecond granularity is likely not needed for any operations that traverse the network.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions