Skip to content

Document password vault support for VSDK plugins #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

Document password vault support for VSDK plugins #347

merged 1 commit into from
Feb 24, 2021

Conversation

rasantel
Copy link
Contributor

Documents the new credentials-supplier feature that lets users choose between entering passwords/keys directly or linking to a password vault.

Preview: https://rasantel.github.io/virtualization-sdk/

Fixes #267 .

mothslaw
mothslaw approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@mothslaw mothslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

We've already started on the release branch, so perhaps this should be merged to release instead of to develop? But, if that's a pain, I can port this over as part of the release work I'm already doing.

ankursarin
ankursarin reviewed Feb 23, 2021
View reviewed changes
Copy link
Contributor

@ankursarin ankursarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not had a chance to review this. quick comment, could you remove DOC-1074 from the title since that is an internal Jira reference?

@rasantel rasantel changed the title DOC-1074 Document password vault support for VSDK plugins Document password vault support for VSDK plugins Feb 24, 2021
@rasantel
Copy link
Contributor Author

Have not had a chance to review this. quick comment, could you remove DOC-1074 from the title since that is an internal Jira reference?

@ankursarin done

@mothslaw mothslaw merged commit 26e9f2c into delphix:develop Feb 24, 2021
mothslaw pushed a commit to mothslaw/virtualization-sdk that referenced this pull request Feb 24, 2021
@rasantel @mothslaw
DOC-1074 Document password vault support for VSDK plugins (delphix#347)
88107d6
mothslaw added a commit that referenced this pull request Feb 24, 2021
@mothslaw @rasantel
DOC-1074 Document password vault support for VSDK plugins (#347) (#349)
d4e1784 
Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
mothslaw added a commit that referenced this pull request Mar 1, 2021
@mothslaw @rasantel
Add release notes for 3.1.0 (#351)
7e40f1f 
* DOC-1074 Document password vault support for VSDK plugins (#347)

* Add release notes for 3.1.0

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
ankursarin pushed a commit to ankursarin/virtualization-sdk that referenced this pull request Sep 10, 2021
@mothslaw @rasantel @ankursarin
Add release notes for 3.1.0 (delphix#351)
ed48dfc 
* DOC-1074 Document password vault support for VSDK plugins (delphix#347)

* Add release notes for 3.1.0

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
ankursarin pushed a commit to ankursarin/virtualization-sdk that referenced this pull request Sep 13, 2021
@mothslaw @rasantel @ankursarin
Add release notes for 3.1.0 (delphix#351)
587bea1 
* DOC-1074 Document password vault support for VSDK plugins (delphix#347)

* Add release notes for 3.1.0

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
mrburke pushed a commit that referenced this pull request Jan 12, 2022
@rasantel @Ranzo3
@jeffngo @ankursarin @kurthdelphix @mothslaw
Release (#418)
8b9899e 
* DOC-1074 Document password vault support for VSDK plugins (#347)

* Correct Typo in Example, it should be UNIX not WINDOWS (#360)

* Add documentation for gRPC message and memory limits #390 (#391)

* Fix version number in doc header (#358) (#397)

* Update Delphix Engine version required to 6.0.7.0. (#386) (#398)

* Update SDK Docs deployment to use a deploy_key (#392) (#399)

* CP-6005 Ensure vSDK test coverage (#403)

* CP-6006 Futurize vSDK - Stage 1 (#404)

* Add support for virtualCleanup decorator (#400) (#405)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Fixes #401 Networking capabilities should be documented (#402)

Fixes #401 Networking capabilities should be documented

* CP-6009 Add to_str and to_byte helpers (#407)

* CP-6621 bump sdk version to 4.0.0 (#409)

* CP-6694 Update docs for SDK 4.0.0 (#410)

* CP-7022 vSDK 4.0.0 release tasks

* Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Update documentation with new gRPC message limits (#415)

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>
mrburke pushed a commit to mrburke/virtualization-sdk that referenced this pull request Jan 13, 2022
@rasantel @Ranzo3
@jeffngo @ankursarin @kurthdelphix @mothslaw
Release (delphix#418)
4b86e80 
* DOC-1074 Document password vault support for VSDK plugins (delphix#347)

* Correct Typo in Example, it should be UNIX not WINDOWS (delphix#360)

* Add documentation for gRPC message and memory limits delphix#390 (delphix#391)

* Fix version number in doc header (delphix#358) (delphix#397)

* Update Delphix Engine version required to 6.0.7.0. (delphix#386) (delphix#398)

* Update SDK Docs deployment to use a deploy_key (delphix#392) (delphix#399)

* CP-6005 Ensure vSDK test coverage (delphix#403)

* CP-6006 Futurize vSDK - Stage 1 (delphix#404)

* Add support for virtualCleanup decorator (delphix#400) (delphix#405)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Fixes delphix#401 Networking capabilities should be documented (delphix#402)

Fixes delphix#401 Networking capabilities should be documented

* CP-6009 Add to_str and to_byte helpers (delphix#407)

* CP-6621 bump sdk version to 4.0.0 (delphix#409)

* CP-6694 Update docs for SDK 4.0.0 (delphix#410)

* CP-7022 vSDK 4.0.0 release tasks

* Update VirtualDelete flow diagram to include the virtual.cleanup call. (delphix#414)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Update documentation with new gRPC message limits (delphix#415)

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>
mrburke pushed a commit that referenced this pull request Jan 13, 2022
@rasantel @Ranzo3
@jeffngo @ankursarin @kurthdelphix @mothslaw
Release (#418) (#421)
681cc56 
* DOC-1074 Document password vault support for VSDK plugins (#347)

* Correct Typo in Example, it should be UNIX not WINDOWS (#360)

* Add documentation for gRPC message and memory limits #390 (#391)

* Fix version number in doc header (#358) (#397)

* Update Delphix Engine version required to 6.0.7.0. (#386) (#398)

* Update SDK Docs deployment to use a deploy_key (#392) (#399)

* CP-6005 Ensure vSDK test coverage (#403)

* CP-6006 Futurize vSDK - Stage 1 (#404)

* Add support for virtualCleanup decorator (#400) (#405)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Fixes #401 Networking capabilities should be documented (#402)

Fixes #401 Networking capabilities should be documented

* CP-6009 Add to_str and to_byte helpers (#407)

* CP-6621 bump sdk version to 4.0.0 (#409)

* CP-6694 Update docs for SDK 4.0.0 (#410)

* CP-7022 vSDK 4.0.0 release tasks

* Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Update documentation with new gRPC message limits (#415)

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>
mrburke pushed a commit that referenced this pull request Jan 20, 2022
@rasantel @Ranzo3
@jeffngo @ankursarin @kurthdelphix @mothslaw
4.0.0 post-release tasks - merge release into develop (#425)
f2b9957 
* CP-7022 vSDK 4.0.0 release tasks (#416)

* Bumping sdk to 4.0.2 and dvp-api to 1.6.3 due to bad upload of dvp-api 1.6.1 to pypi (#419)

* Release (#418)

* DOC-1074 Document password vault support for VSDK plugins (#347)

* Correct Typo in Example, it should be UNIX not WINDOWS (#360)

* Add documentation for gRPC message and memory limits #390 (#391)

* Fix version number in doc header (#358) (#397)

* Update Delphix Engine version required to 6.0.7.0. (#386) (#398)

* Update SDK Docs deployment to use a deploy_key (#392) (#399)

* CP-6005 Ensure vSDK test coverage (#403)

* CP-6006 Futurize vSDK - Stage 1 (#404)

* Add support for virtualCleanup decorator (#400) (#405)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Fixes #401 Networking capabilities should be documented (#402)

Fixes #401 Networking capabilities should be documented

* CP-6009 Add to_str and to_byte helpers (#407)

* CP-6621 bump sdk version to 4.0.0 (#409)

* CP-6694 Update docs for SDK 4.0.0 (#410)

* CP-7022 vSDK 4.0.0 release tasks

* Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Update documentation with new gRPC message limits (#415)

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>

* Release (#418) (#421)

* DOC-1074 Document password vault support for VSDK plugins (#347)

* Correct Typo in Example, it should be UNIX not WINDOWS (#360)

* Add documentation for gRPC message and memory limits #390 (#391)

* Fix version number in doc header (#358) (#397)

* Update Delphix Engine version required to 6.0.7.0. (#386) (#398)

* Update SDK Docs deployment to use a deploy_key (#392) (#399)

* CP-6005 Ensure vSDK test coverage (#403)

* CP-6006 Futurize vSDK - Stage 1 (#404)

* Add support for virtualCleanup decorator (#400) (#405)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Fixes #401 Networking capabilities should be documented (#402)

Fixes #401 Networking capabilities should be documented

* CP-6009 Add to_str and to_byte helpers (#407)

* CP-6621 bump sdk version to 4.0.0 (#409)

* CP-6694 Update docs for SDK 4.0.0 (#410)

* CP-7022 vSDK 4.0.0 release tasks

* Update VirtualDelete flow diagram to include the virtual.cleanup call. (#414)

Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>

* Update documentation with new gRPC message limits (#415)

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>

Co-authored-by: Raul Santelices <rasantel@users.noreply.github.com>
Co-authored-by: Ranzo J Taylor, III <36489926+Ranzo3@users.noreply.github.com>
Co-authored-by: Jeff Ngo <35587243+jeffngo@users.noreply.github.com>
Co-authored-by: Ankur <ankursarin@gmail.com>
Co-authored-by: kurthdelphix <89274759+kurthdelphix@users.noreply.github.com>
Co-authored-by: Kurt Hutchison <kurth.hutchison@delphix.com>
Co-authored-by: Tom Walsh <61519496+mothslaw@users.noreply.github.com>
@vimleshmishra vimleshmishra mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankursarin ankursarin ankursarin left review comments

@nhlien93 nhlien93 nhlien93 approved these changes

@mothslaw mothslaw mothslaw approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document password vault support for VSDK plugins
4 participants
@rasantel @ankursarin @nhlien93 @mothslaw