Print IPv4 address correctly on little-endian systems #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPv4 addresses in
/proc/tcp
are not converted to host order before being printed by the kernel, so they have least-significant byte first on little-endian systems (see https://github.com/torvalds/linux/blob/0f1a7b3fac0583083ca19d4de47403511ced3521/net/ipv4/tcp_ipv4.c#L2460). We need to convert them back to network order when parsing them.Previous output:
Fixed output:
I also added a follow-up commit which improves the error handling in the relevant function and adds tests for it.
ab-pre-push: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/2263/
Fixes #1