Skip to content

Use Github action to run tests against PRs #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Use Github action to run tests against PRs #12

merged 1 commit into from
Jun 17, 2020

Conversation

gllghr
Copy link
Contributor

@gllghr gllghr commented Jun 17, 2020

Closes #11

@gllghr
Copy link
Contributor Author

gllghr commented Jun 17, 2020

cc @sebroy

sebroy
sebroy approved these changes Jun 17, 2020
View reviewed changes
Copy link

@sebroy sebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick!

@gllghr
Copy link
Contributor Author

gllghr commented Jun 17, 2020

The action didn't run here, so I'm guessing it has to be merged before it starts working. I tested it in my fork though (gllghr#2), so I'll go ahead and merge this.

@johngallagher-dlpx johngallagher-dlpx merged commit 31fbb25 into delphix:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsurya prakashsurya prakashsurya approved these changes

@sebroy sebroy sebroy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing and code style checks via GitHub Actions for PR context
4 participants
@gllghr @prakashsurya @sebroy @johngallagher-dlpx