DLPX-78745 Apply estat iscsi approach to stbtrace script #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the estat iscsi script was overhauled. The stbtrace script suffers from some of the same issues that the estat script had, most notably missing write events and reporting incorrect throughput. This commit rewrites the probe functions in the iscsi stbtrace script. It uses the same probe functions as the estat version. They have different aggregate_data functions.
For testing the output was compared to the estat output to verify it's correctness: