Skip to content

DLPX-72430 Estat zil fails to run because of unknown types #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

brad-lewis
Copy link
Contributor

@brad-lewis brad-lewis commented Oct 23, 2020

The estat zil command fails to load with the unknown type errors as show below.

$ sudo estat zil
In file included from <built-in>:3:
/virtual/include/bcc/helpers.h:47:9: warning: 'CC_USING_FENTRY' macro redefined [-Wmacro-redefined]
#define CC_USING_FENTRY
        ^
<command line>:6:9: note: previous definition is here
#define CC_USING_FENTRY 1
        ^
In file included from /virtual/main.c:9:
In file included from /usr/src/zfs-5.4.0-48-generic/include/sys/zfs_znode.h:30:
In file included from /usr/src/zfs-5.4.0-48-generic/include/sys/zfs_acl.h:35:
/usr/src/zfs-5.4.0-48-generic/include/sys/zfs_fuid.h:101:30: error: unknown type name 'zfsvfs_t'

There is also a warning about CC_USING_FENTRY that can be cleaned up. The zil script is a standalone and sets up it's own bpf include path. This change brings it in line with what estat uses for built in scripts and what the built in scripts like zpl include to access zfsvfs_t type.

I tested that the script loaded on esx and aws vms:

Running on esx(Linux 5.4.0-48-generic x86_64):
$ sudo ./estat.py zil
Tracing enabled... Hit Ctrl-C to end.
....

Running on aws(Linux 5.4.0-1025-aws x86_64)
$ sudo ./estat.py zil
Tracing enabled... Hit Ctrl-C to end.
...

@brad-lewis brad-lewis merged commit 7451798 into delphix:master Oct 26, 2020
@brad-lewis brad-lewis deleted the zil_undefinded branch October 26, 2020 20:11
brad-lewis added a commit to brad-lewis/performance-diagnostics that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants