Skip to content

Throughput values are not normalized #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

brad-lewis
Copy link
Contributor

closes #23

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: 23

What is the new behavior?

Throughput now normalized so that it is truly kb/s.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Here is some output showing the throughput correctly reported:

$ sudo ./cmd/estat.py zio  1
...
                                      iops(/s)  avg latency(us)       stddev(us)  throughput(k/s)
 write, syncw                                 8             2143          5498292              120

                                       iops(/s)  throughput(k/s)
 total                                        8              120

$ sudo ./cmd/estat.py zio  10
...
                                      iops(/s)  avg latency(us)       stddev(us)  throughput(k/s)
 write, asyncw                               23             1938          5616501              105
 write, syncw                                11             7970          9586502              144


                                       iops(/s)  throughput(k/s)
 total                                       34              249

$ sudo ./cmd/estat.py zio -N 10
...
                                      iops(/s)  avg latency(us)       stddev(us)    throughput(k)
 write, asyncw                              233             1397          3168196             1015
 write, syncw                               116            14535         21605727             1950


                                       iops(/s)    throughput(k)
 total                                      349             2965


@brad-lewis brad-lewis force-pushed the normalize_throughput branch from 6b27ad2 to c96af1e Compare January 3, 2020 19:20
@brad-lewis
Copy link
Contributor Author

Flake8 indentation issues.

@brad-lewis brad-lewis force-pushed the normalize_throughput branch from c96af1e to 4390926 Compare January 10, 2020 18:18
@brad-lewis
Copy link
Contributor Author

I removed the normalization option and made normalization the only mode. I verfied that throughput and iops are on the same order for runs with durations that are an order of magnitude apart:

$ sudo cmd/estat.py zio 1
...
                                       iops(/s)  avg latency(us)       stddev(us)  throughput(k/s)
 write, syncw                                10              754            24243              128


                                       iops(/s)  throughput(k/s)
 total                                       10              128
 $ sudo cmd/estat.py zio 10
...
                                       iops(/s)  avg latency(us)       stddev(us)  throughput(k/s)
 write, asyncw                               23              621            25695              130
 write, syncw                                10              752           198080              111


                                       iops(/s)  throughput(k/s)
 total                                       34              241


@sebroy
Copy link
Contributor

sebroy commented Jan 10, 2020

@brad-lewis I'll merge this once you rebase on current master.

@brad-lewis brad-lewis force-pushed the normalize_throughput branch from 4390926 to f6c9cf9 Compare January 10, 2020 23:19
@brad-lewis brad-lewis merged commit 37906d7 into delphix:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Throughput values are not normalized
3 participants