Skip to content

Commit a118ff6

Browse files
piso77davem330
authored andcommitted
selftests: net: devlink_port_split: check devlink returned an element before dereferencing it
And thus avoid a Python stacktrace: ~/linux/tools/testing/selftests/net$ ./devlink_port_split.py Traceback (most recent call last): File "/home/linux/tools/testing/selftests/net/./devlink_port_split.py", line 277, in <module> main() File "/home/linux/tools/testing/selftests/net/./devlink_port_split.py", line 242, in main dev = list(devs.keys())[0] IndexError: list index out of range Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b856150 commit a118ff6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tools/testing/selftests/net/devlink_port_split.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,9 @@ def main(cmdline=None):
239239
assert stderr == ""
240240

241241
devs = json.loads(stdout)['dev']
242+
if len(devs.keys()) == 0:
243+
print("no devlink device found")
244+
sys.exit(1)
242245
dev = list(devs.keys())[0]
243246

244247
cmd = "devlink dev show %s" % dev

0 commit comments

Comments
 (0)