Skip to content

DLPX-84906 Disable frame buffer drivers #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

DLPX-84906 Disable frame buffer drivers #26

merged 1 commit into from
May 9, 2023

Conversation

sumedhbala-delphix
Copy link
Contributor

@sumedhbala-delphix sumedhbala-delphix force-pushed the dlpx/pr/sumedhbala-delphix/0c48d30e-90ec-48a3-92c5-8bdc064d6e15 branch from 6abb5fb to 73587ca Compare May 8, 2023 14:28
@sumedhbala-delphix sumedhbala-delphix requested a review from sebroy May 9, 2023 01:23
@sumedhbala-delphix sumedhbala-delphix marked this pull request as ready for review May 9, 2023 14:29
@sumedhbala-delphix sumedhbala-delphix merged commit 91267b7 into develop May 9, 2023
@sumedhbala-delphix sumedhbala-delphix deleted the dlpx/pr/sumedhbala-delphix/0c48d30e-90ec-48a3-92c5-8bdc064d6e15 branch May 9, 2023 14:29
prakashsurya pushed a commit that referenced this pull request May 18, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
f9f50b2 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request May 26, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
81ef925 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Jun 3, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
617a7f8 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Jun 4, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
298a719 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Jun 5, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
da6b5a2 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
prakashsurya pushed a commit that referenced this pull request Aug 8, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
5e2e08c 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Sep 1, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
a76f0c7 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Sep 2, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
dde22bd 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Sep 13, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
8c469d5 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Sep 20, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
dc7ed69 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Oct 6, 2023
@smb49
blk-iocost: use spin_lock_irqsave in adjust_inuse_and_calc_cost
14000b1 
BugLink: https://bugs.launchpad.net/bugs/2032689

[ Upstream commit 8d21155 ]

adjust_inuse_and_calc_cost() use spin_lock_irq() and IRQ will be enabled
when unlock. DEADLOCK might happen if we have held other locks and disabled
IRQ before invoking it.

Fix it by using spin_lock_irqsave() instead, which can keep IRQ state
consistent with before when unlock.

  ================================
  WARNING: inconsistent lock state
  5.10.0-02758-g8e5f91fd772f #26 Not tainted
  --------------------------------
  inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage.
  kworker/2:3/388 [HC0[0]:SC0[0]:HE0:SE1] takes:
  ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: spin_lock_irq
  ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: bfq_bio_merge+0x141/0x390
  {IN-HARDIRQ-W} state was registered at:
    __lock_acquire+0x3d7/0x1070
    lock_acquire+0x197/0x4a0
    __raw_spin_lock_irqsave
    _raw_spin_lock_irqsave+0x3b/0x60
    bfq_idle_slice_timer_body
    bfq_idle_slice_timer+0x53/0x1d0
    __run_hrtimer+0x477/0xa70
    __hrtimer_run_queues+0x1c6/0x2d0
    hrtimer_interrupt+0x302/0x9e0
    local_apic_timer_interrupt
    __sysvec_apic_timer_interrupt+0xfd/0x420
    run_sysvec_on_irqstack_cond
    sysvec_apic_timer_interrupt+0x46/0xa0
    asm_sysvec_apic_timer_interrupt+0x12/0x20
  irq event stamp: 837522
  hardirqs last  enabled at (837521): [<ffffffff84b9419d>] __raw_spin_unlock_irqrestore
  hardirqs last  enabled at (837521): [<ffffffff84b9419d>] _raw_spin_unlock_irqrestore+0x3d/0x40
  hardirqs last disabled at (837522): [<ffffffff84b93fa3>] __raw_spin_lock_irq
  hardirqs last disabled at (837522): [<ffffffff84b93fa3>] _raw_spin_lock_irq+0x43/0x50
  softirqs last  enabled at (835852): [<ffffffff84e00558>] __do_softirq+0x558/0x8ec
  softirqs last disabled at (835845): [<ffffffff84c010ff>] asm_call_irq_on_stack+0xf/0x20

  other info that might help us debug this:
   Possible unsafe locking scenario:

         CPU0
         ----
    lock(&bfqd->lock);
    <Interrupt>
      lock(&bfqd->lock);

   *** DEADLOCK ***

  3 locks held by kworker/2:3/388:
   #0: ffff888107af0f38 ((wq_completion)kthrotld){+.+.}-{0:0}, at: process_one_work+0x742/0x13f0
   #1: ffff8881176bfdd8 ((work_completion)(&td->dispatch_work)){+.+.}-{0:0}, at: process_one_work+0x777/0x13f0
   #2: ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: spin_lock_irq
   #2: ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: bfq_bio_merge+0x141/0x390

  stack backtrace:
  CPU: 2 PID: 388 Comm: kworker/2:3 Not tainted 5.10.0-02758-g8e5f91fd772f #26
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
  Workqueue: kthrotld blk_throtl_dispatch_work_fn
  Call Trace:
   __dump_stack lib/dump_stack.c:77 [inline]
   dump_stack+0x107/0x167
   print_usage_bug
   valid_state
   mark_lock_irq.cold+0x32/0x3a
   mark_lock+0x693/0xbc0
   mark_held_locks+0x9e/0xe0
   __trace_hardirqs_on_caller
   lockdep_hardirqs_on_prepare.part.0+0x151/0x360
   trace_hardirqs_on+0x5b/0x180
   __raw_spin_unlock_irq
   _raw_spin_unlock_irq+0x24/0x40
   spin_unlock_irq
   adjust_inuse_and_calc_cost+0x4fb/0x970
   ioc_rqos_merge+0x277/0x740
   __rq_qos_merge+0x62/0xb0
   rq_qos_merge
   bio_attempt_back_merge+0x12c/0x4a0
   blk_mq_sched_try_merge+0x1b6/0x4d0
   bfq_bio_merge+0x24a/0x390
   __blk_mq_sched_bio_merge+0xa6/0x460
   blk_mq_sched_bio_merge
   blk_mq_submit_bio+0x2e7/0x1ee0
   __submit_bio_noacct_mq+0x175/0x3b0
   submit_bio_noacct+0x1fb/0x270
   blk_throtl_dispatch_work_fn+0x1ef/0x2b0
   process_one_work+0x83e/0x13f0
   process_scheduled_works
   worker_thread+0x7e3/0xd80
   kthread+0x353/0x470
   ret_from_fork+0x1f/0x30

Fixes: b0853ab ("blk-iocost: revamp in-period donation snapbacks")
Signed-off-by: Li Nan <linan122@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20230527091904.3001833-1-linan666@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
delphix-devops-bot pushed a commit that referenced this pull request Oct 6, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
f212c4b 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Oct 21, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
114044b 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Oct 22, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
8875cc0 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Nov 1, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
893910c 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Dec 1, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
ef5d5cf 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Dec 9, 2023
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
58213ec 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Jan 27, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
e63f258 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Feb 17, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
24c86d5 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Feb 18, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
81713a3 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Feb 19, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
b2f7e10 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Feb 20, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
ede6137 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Mar 22, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
a6ccb95 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Mar 23, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
110e579 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit to jwk404/linux-kernel-azure that referenced this pull request Mar 23, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (delphix#26)
10e9db8 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Mar 24, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
f500585 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Mar 25, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
5ccb579 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit to jwk404/linux-kernel-azure that referenced this pull request Mar 25, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (delphix#26)
1d68738 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Mar 26, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
56d7d48 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Mar 27, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
6f0827e 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit that referenced this pull request Apr 10, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (#26)
5cd662c 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit that referenced this pull request Apr 10, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (#26)
b54087c 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit that referenced this pull request Apr 11, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (#26)
9704e58 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit that referenced this pull request Apr 14, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (#26)
cceb2ea 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit that referenced this pull request Apr 15, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (#26)
f5db35b 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit that referenced this pull request Apr 15, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (#26)
8dc205f 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
jwk404 pushed a commit that referenced this pull request Apr 15, 2024
@sumedhbala-delphix @jwk404
DLPX-84906 Disable frame buffer drivers (#26)
af9815a 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Apr 20, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
69aa9cb 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request May 9, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
d27ac79 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request May 16, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
f009ceb 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Jun 30, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
f910b73 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Aug 1, 2024
@sumedhbala-delphix @manoj-joseph
DLPX-84906 Disable frame buffer drivers (#26)
e4fce79 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Aug 6, 2024
@sumedhbala-delphix @manoj-joseph
DLPX-84906 Disable frame buffer drivers (#26)
6edf4de 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
pcd1193182 pushed a commit to pcd1193182/linux-kernel-azure that referenced this pull request Aug 19, 2024
@sumedhbala-delphix @pcd1193182
DLPX-84906 Disable frame buffer drivers (delphix#26)
3363123 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Aug 22, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
ae0081f 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Aug 23, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
1890445 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
prakashsurya pushed a commit that referenced this pull request Sep 23, 2024
@sumedhbala-delphix @prakashsurya
DLPX-84906 Disable frame buffer drivers (#26)
0cfc1a0 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Oct 20, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
96659b3 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
palash-gandhi pushed a commit that referenced this pull request Oct 24, 2024
@sumedhbala-delphix @palash-gandhi
DLPX-84906 Disable frame buffer drivers (#26)
f0cdcac 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Nov 23, 2024
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
f6a9c5f 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Jan 10, 2025
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
47d2a97 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
delphix-devops-bot pushed a commit that referenced this pull request Feb 1, 2025
@sumedhbala-delphix
DLPX-84906 Disable frame buffer drivers (#26)
b38ed2b 
PR URL: https://www.github.com/delphix/linux-kernel-azure/pull/26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsurya prakashsurya prakashsurya approved these changes

@sebroy sebroy sebroy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumedhbala-delphix @prakashsurya @sebroy