Skip to content

DLPX-93404 LTS 24.04: delphix-rust must explicitly state that it provides rustfmt & cargo-fmt #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

palash-gandhi
Copy link

@palash-gandhi palash-gandhi commented Feb 14, 2025

Problem:

delphix-rust provides cargo-fmt and rustfmt but does not explicitly specify it.
This causes conflicts when building a package that requires these.

Solution:

Specify them.

Testing

build-package: https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/linux-pkg/job/os-upgrade/job/build-package/job/delphix-rust/job/pre-push/70/console

delphix@pg-fluent:~$ /export/home/delphix/.local/bin/aws s3 cp s3://dev-de-images/builds/jenkins-ops/linux-pkg/os-upgrade/build-package/delphix-rust/pre-push/70/delphix-rust_1.80.0-1delphix.2025.02.14.21.55_amd64.deb .
download: s3://dev-de-images/builds/jenkins-ops/linux-pkg/os-upgrade/build-package/delphix-rust/pre-push/70/delphix-rust_1.80.0-1delphix.2025.02.14.21.55_amd64.deb to ./delphix-rust_1.80.0-1delphix.2025.02.14.21.55_amd64.deb

delphix@pg-fluent:~$ dpkg -I delphix-rust_1.80.0-1delphix.2025.02.14.21.55_amd64.deb
 new Debian package, version 2.0.
 size 223817714 bytes: control archive=854967 bytes.
     590 bytes,    11 lines      control
 4117037 bytes, 39921 lines      md5sums
 Package: delphix-rust
 Version: 1.80.0-1delphix.2025.02.14.21.55
 Architecture: amd64
 Maintainer: Delphix Engineering <eng@delphix.com>
 Installed-Size: 1320675
 Conflicts: cargo, cargo-fmt, rust-gdb, rustc, rustfmt
 Provides: cargo (= 1.80.0-1delphix.2025.02.14.21.55), cargo-fmt (= 1.80.0-1delphix.2025.02.14.21.55), rust-gdb (= 1.80.0-1delphix.2025.02.14.21.55), rustc (= 1.80.0-1delphix.2025.02.14.21.55), rustfmt (= 1.80.0-1delphix.2025.02.14.21.55)
 Section: misc
 Priority: optional
 Description: Rust - A programming language empowering everyone to build
   reliable and efficient software.

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/c7401e49-3dbb-4bcc-b299-7aaf3386eca0 branch from 78a4560 to bdfaada Compare February 14, 2025 21:47
@palash-gandhi palash-gandhi marked this pull request as ready for review February 14, 2025 21:51
@palash-gandhi palash-gandhi enabled auto-merge (squash) February 14, 2025 22:34
@palash-gandhi palash-gandhi merged commit 15b4240 into os-upgrade Feb 14, 2025
4 of 5 checks passed
@palash-gandhi palash-gandhi deleted the dlpx/pr/palash-gandhi/c7401e49-3dbb-4bcc-b299-7aaf3386eca0 branch February 14, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants