Skip to content

DLPX-87464 Add netcat package to list of dependencies #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

prakashsurya
Copy link
Contributor

No description provided.

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/8a8928b3-b44f-4201-9cf0-6323fadb1d61 branch from 3c3d544 to 3b172b5 Compare August 11, 2023 15:20
@prakashsurya prakashsurya requested a review from sebroy August 11, 2023 15:22
Copy link
Contributor

@sebroy sebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What set of new dependencies does this bring in (if any)?

@sebroy
Copy link
Contributor

sebroy commented Aug 11, 2023

Based on internal discussions, it's not clear that there's sufficient justification for adding this to the image.

@prakashsurya
Copy link
Contributor Author

Based on internal discussions, it's not clear that there's sufficient justification for adding this to the image.

Should I go ahead and close this as "won't fix"?

@sebroy
Copy link
Contributor

sebroy commented Aug 14, 2023

Should I go ahead and close this as "won't fix"?

It looks like there may still be some use cases not addressed by our APIs. Let's go ahead and move forward with this, and we can file separate Jira issues representing the gaps in functionality.

@prakashsurya
Copy link
Contributor Author

prakashsurya commented Aug 16, 2023

I ran the following command before and after this change:

$ dpkg-query -Wf '${Package}\n' | sort

Here's the diff:

$ diff pkgs-before.txt pkgs-after.txt
495a496,497
> netcat
> netcat-openbsd

looks like it's not pulling in any other dependencies.

I'll make the change from depending on netcat to netcat-openbsd.. I think we're good otherwise.

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/8a8928b3-b44f-4201-9cf0-6323fadb1d61 branch from 3b172b5 to 78c244a Compare August 16, 2023 16:45
@prakashsurya prakashsurya changed the title Add netcat package to list of dependencies DLPX-87464 Add netcat package to list of dependencies Aug 16, 2023
@prakashsurya prakashsurya marked this pull request as ready for review August 16, 2023 16:46
@prakashsurya prakashsurya enabled auto-merge (squash) August 16, 2023 16:47
@prakashsurya prakashsurya merged commit cea781e into develop Aug 16, 2023
@prakashsurya prakashsurya deleted the dlpx/pr/prakashsurya/8a8928b3-b44f-4201-9cf0-6323fadb1d61 branch August 16, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants