Skip to content

TOOL-10945 Add SSH keys to OCI instances using cloud init #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

grwilson
Copy link
Contributor

@grwilson grwilson commented Apr 8, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, it is not possible to add ssh keys to our internal variants on OCI. This is because we have been using NoCloud as the cloud-init datasource.

What is the new behavior?

This PR changes the behavior for the internal variants by allowing OCI to use the OpenStack datasource.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@grwilson grwilson requested review from prakashsurya and sebroy April 8, 2021 14:19
@sebroy
Copy link
Contributor

sebroy commented Apr 8, 2021

Can you remind me what prevents ssh keys to be installed on the external variant?

@grwilson
Copy link
Contributor Author

grwilson commented Apr 9, 2021

Can you remind me what prevents ssh keys to be installed on the external variant?

This is handled by appliance-build. In there we add the following files to our internal builds in live-build/misc/ansible-roles/appliance-build.minimal-internal/tasks/main.yml:

allow_public_ssh_keys: true

@grwilson
Copy link
Contributor Author

@grwilson grwilson merged commit 3d95ed3 into delphix:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants