Skip to content

DLPX-75089 Upgrade verification should not enable nfs services #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2021
Merged

DLPX-75089 Upgrade verification should not enable nfs services #277

merged 1 commit into from
Apr 5, 2021

Conversation

prakashsurya
Copy link
Contributor

No description provided.

@prakashsurya prakashsurya requested review from don-brady and sebroy April 1, 2021 18:00
@prakashsurya
Copy link
Contributor Author

prakashsurya commented Apr 1, 2021 •
edited
Loading

git-ab-pre-push is here

sebroy
sebroy reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@sebroy sebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add testing details to the PR explaining how you verified that this fix works?

@prakashsurya
Copy link
Contributor Author

Can you add testing details to the PR explaining how you verified that this fix works?

Sure; using the VM image generated via the git-ab-pre-push, I created an "in-place" upgrade container, and then verified the services were not running within that container.. e.g.

$ sudo /var/dlpx-update/latest/upgrade-container shell delphix.vufbETp
Connected to machine delphix.vufbETp. Press ^] three times within 1s to exit session.
root@ip-10-110-237-22:~# systemctl status nfs-server
● nfs-server.service - NFS server and services
   Loaded: loaded (/lib/systemd/system/nfs-server.service; enabled; vendor preset: enabled)
  Drop-In: /lib/systemd/system/nfs-server.service.d
           └─override.conf
   Active: inactive (dead)
Condition: start condition failed at Mon 2021-04-05 19:45:07 UTC; 22s ago
           └─ ConditionVirtualization=!container was not met

@prakashsurya prakashsurya merged commit 4503d10 into delphix:master Apr 5, 2021
prakashsurya pushed a commit to prakashsurya/delphix-platform that referenced this pull request Apr 5, 2021
DLPX-75089 Upgrade verification should not enable nfs services (delph…
a23853c 
…ix#277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebroy sebroy sebroy approved these changes

@don-brady don-brady don-brady approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakashsurya @sebroy @don-brady