DLPX-74854 Update /usr/bin/get-appliance-version to also report the h…

[skinner-m-c]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build was run locally and any changes were pushed
• Lint has passed locally and any fixes were made for failures

Test run

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Current script does not report the hotfix version.
Issue Number: DLPX-74854

What is the new behavior?

Due to changes in delphix/appliance-build#507 and with ongoing work in hotfixes, the version is stored in a ZFS property. For the sake of consistency the hotfix version should be reported in this tool. Because we are not changing the Delphix version string, the hotfix version is not included in the version string, but is a separate value.

Does this introduce a breaking change?

• Yes
• No

Other information

[prakashsurya]

Since the hotfix-version field is completely separate from the current-version field, and the implementation of retrieving and parsing is independent, how would you feel about creating a new script (e.g. get-hotfix-version) to retrieve the hotfix version?

I might be able to be convinced otherwise, but I sort of feel that the two versions are distinct enough, that perhaps using a separate script might be more appropriate. This might also make it a little more apparent when reading consumer logic, that we're getting the hotfix version; e.g. we'd see get-hotfix-version rather than get-appliance-version -f, which to me is easier to immediately see what "version" we're retrieving.

What do you think?

[skinner-m-c]

@prakashsurya I am open to a new script. I'll wait a little before proceeding to see if others have other ideas and opinions.

[prakashsurya]

Looks good! Thank you.