Skip to content

CP-4790 Reserve a port for the libs server in delphix-platform #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

jeffngo
Copy link
Contributor

@jeffngo jeffngo commented Mar 9, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: CP-4790

We are currently reserving 3 ports for nfsv3, and we would like to add another reserved port for the virtualization sdk libs server.

What is the new behavior?

Added a reserved port for the libs server in delphix-platform (54046)

Does this introduce a breaking change?

  • Yes
  • No

Other information

ab-pre-push: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4902/

@jeffngo jeffngo requested review from sebroy, pzakha and don-brady March 9, 2021 22:40
@jeffngo jeffngo self-assigned this Mar 9, 2021
@pzakha
Copy link
Contributor

pzakha commented Mar 9, 2021

Changes LGTM. Can you mention the tests that you've run? (Ideally, that would also include a link to ab-pre-push)

@jeffngo
Copy link
Contributor Author

jeffngo commented Mar 9, 2021

Changes LGTM. Can you mention the tests that you've run? (Ideally, that would also include a link to ab-pre-push)

Link to ab-pre-push (also in PR description now): http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/4902/

Copy link
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending completion of tests

Copy link

@ravi-cm ravi-cm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeffngo jeffngo merged commit 9eff7b0 into delphix:master Mar 12, 2021
jeffngo added a commit to jeffngo/delphix-platform that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants