DLPX-71608 Remove delphix-buildinfo packages as they will no longer be built #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsurya
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Can you please add information to the PR description about which workflows will no longer work? i.e. what sorts of things did these packages previously enable, and what sorts of things will we no longer be able to do? Does this mean we can no longer map the software that's installed on the system, to the git repository information that was use to build that software?
That's right. I've updated the description. |
brad-lewis
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the work done in TOOL-9778, each package will be built individually and we will no longer build delphix-buildinfo-userland and delphix-buildinfo-kernel packages, so those have to be removed from the delphix-platform's package dependencies.
Those packages are not currently used by the product, but are useful for QA/developers to figure out what git commit was used to build packages that are installed on the appliance.
We will need to think of an alternative way to get the buildinfo onto the engine as it was quite useful, and I've proposed an idea in DLPX-71683.
Testing
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/3935/