Automatically determine image variant if not specified #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
grwilson
approved these changes
Oct 28, 2020
pzakha
approved these changes
Oct 28, 2020
prakashsurya
force-pushed
the
download-image
branch
from
0876410 to
a8863d1
Compare
This change optimizes the UX of "download-latest-image" script, such that the user does not necessarily have to specify the image variant to be downloaded. This is useful for the case where the script is run on an existing Delphix appliance, and the user wants the script to download the image variant that matches the appliance it's being run on. In this case, the script can (and now does, with this change) detect the variant of the appliance, and download the corresponding image, without forcing the user to specify which variant to download.
prakashsurya
force-pushed
the
download-image
branch
from
a8863d1 to
3f34e85
Compare
prakashsurya
pushed a commit
to prakashsurya/delphix-platform
that referenced
this pull request
Oct 28, 2020
This change optimizes the UX of "download-latest-image" script, such that the user does not necessarily have to specify the image variant to be downloaded. This is useful for the case where the script is run on an existing Delphix appliance, and the user wants the script to download the image variant that matches the appliance it's being run on. In this case, the script can (and now does, with this change) detect the variant of the appliance, and download the corresponding image, without forcing the user to specify which variant to download.
prakashsurya
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Add "-b" to allowing downloading non-master image This change extends the "download-latest-image" script to add the "-b" option which allows the user to specify which branch to use when downloading the upgrade image. * Add "-N" to allowing downloading nightly image This change extends the "download-latest-image" script to add the "-N" option which allows the user to specify whether to download from the "nightly" build, or use the default "post-push" build. * Automatically determine image variant if not specified (#241) This change optimizes the UX of "download-latest-image" script, such that the user does not necessarily have to specify the image variant to be downloaded. This is useful for the case where the script is run on an existing Delphix appliance, and the user wants the script to download the image variant that matches the appliance it's being run on. In this case, the script can (and now does, with this change) detect the variant of the appliance, and download the corresponding image, without forcing the user to specify which variant to download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change optimizes the UX of "download-latest-image" script, such
that the user does not necessarily have to specify the image variant to
be downloaded.
This is useful for the case where the script is run on an existing
Delphix appliance, and the user wants the script to download the image
variant that matches the appliance it's being run on.
In this case, the script can (and now does, with this change) detect the
variant of the appliance, and download the corresponding image, without
forcing the user to specify which variant to download.