Skip to content

DLPX-67674 disable vmtools balloon driver #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2019
Merged

DLPX-67674 disable vmtools balloon driver #171

merged 1 commit into from
Dec 11, 2019

Conversation

grwilson
Copy link
Contributor

No description provided.

@grwilson
Copy link
Contributor Author

ab-pre-push

prakashsurya
prakashsurya approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can we combine this with the existing file used to blacklist the floppy driver? perhaps renaming the file to something like delphix.conf at the same time? I just feel like having less files might make things easier to understand.

pzakha
pzakha approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A combined delphix.conf file might be better indeed, and perhaps with can also add an install directive for the floppy driver just in case.

@grwilson
Copy link
Contributor Author

I updated this to a single file and add the install directive to the floppy drive.

@sebroy sebroy merged commit d3d0fd8 into delphix:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsurya prakashsurya prakashsurya approved these changes

@pzakha pzakha pzakha approved these changes

Assignees

@prakashsurya prakashsurya

@pzakha pzakha

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grwilson @prakashsurya @pzakha @sebroy