DLPX-67394 Increase postgres service timeout during migration (Part 2 of 2) #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebroy
approved these changes
Nov 14, 2019
grwilson
approved these changes
Nov 15, 2019
|
bors delegate+ |
|
✌️ pzakha can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 21, 2019
161: DLPX-67394 Increase postgres service timeout during migration (Part 2 of 2) r=pzakha a=pzakha Part 1 of 2: http://reviews.delphix.com/r/54101 See JIRA for description. Caveat: For the internal-dev variant we deploy other override.conf files under `/etc/systemd/...`, so the files for the same service under `/run/systemd/...` are ignored by systemd. An alternative would be to edit `/etc/systemd` files instead, but the logic would be more complex and prone to failure, so I've opted for this instead. ## Testing Testing this change only: - migration: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/2490/ Testing both parts together: see http://reviews.delphix.com/r/54101 Co-authored-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Build succeeded
|
bors bot
added a commit
that referenced
this pull request
Nov 22, 2019
166: DLPX-67396 [Backport of Issue DLPX-67394 to 6.0.0.0] Increase postgres service timeout during migration r=pzakha a=pzakha Backport of #161 ## Testing migration: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/2535/ Co-authored-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of 2: http://reviews.delphix.com/r/54101
See JIRA for description.
Caveat:
For the internal-dev variant we deploy other override.conf files under
/etc/systemd/..., so the files for the same service under/run/systemd/...are ignored by systemd. An alternative would be to edit/etc/systemdfiles instead, but the logic would be more complex and prone to failure, so I've opted for this instead.Testing
Testing this change only:
Testing both parts together: see http://reviews.delphix.com/r/54101