Skip to content

DLPX-67281 Network configuration not migrated because of multiple netplan files #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2019
Merged

DLPX-67281 Network configuration not migrated because of multiple netplan files #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions files/common/lib/systemd/system/delphix-migration.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,22 @@
# local-fs.target, it is better to be more explicit in case we decided to
# remove the latter.
#
# The OS network migration code, even though it doesn't list the
# netplan file generated by cloud-init as a hard dependency, it can
# experience a race as the one pointed in DLPX-67281, where the
# cloud-init-local service runs around the same time and generates
# the default netplan file while we write our custom one on-disk
# through the netconf-migrator. This is bad because we end up with two
# netplan files that can have conflicting information for networkd.
# To avoid this scenario, we make sure that this service runs AFTER
# cloud-init-local.
#
[Unit]
Description=Delphix OS Migration Service
PartOf=delphix.target
DefaultDependencies=no
After=systemd-udev-settle.service
After=cloud-init-local.service
After=var-delphix.mount
After=local-fs.target
Before=network-pre.target
Expand Down